Closed GregHanson closed 2 months ago
@GregHanson Hey there! Thanks for your contribution, it is much appreciated! Since you're the second one to ask for this feature, I'm willing to accept it. However, I'd prefer if it was behind a feature gate that is opt-out by default
done! I think I did that right since my import of the branch compiles
Thanks! I'll look into it as soon as possible when I come back from vacations!
Hey @GregHanson !
Thanks for the contribution ! I reviewed it, it works and it's a nice addition to the crate, thanks !
You didn't put Serialize
on every struct though, is there a reason for that ?
Do you mind adding this to all structs that are already Deserialize
?
I can merge it as is if you want, and I'll do it myself if you prefer.
Please let me know !
you are right! that was my mistake. I think I got them all now
Thanks for your contribution ! I'll make a release right away !
minor change, but could
serde::Serialize
be included with all PokeAPI structs? I'd like to be able to export the data I retrieve from the library to other tooling/libraries