search

mlr-org / mlr3tuning

Hyperparameter optimization package of the mlr3 ecosystem
https://mlr3tuning.mlr-org.com/
GNU Lesser General Public License v3.0
54 stars 5 forks source link

remove terminator check after eval_batch, fix issue 201 #211

Closed berndbischl closed 4 years ago

berndbischl commented 4 years ago

should fix #210 @mb706 can you pls check then we can merge

codecov-io commented 4 years ago

Codecov Report

Merging #211 into master will decrease coverage by 0.05%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #211      +/-   ##
==========================================
- Coverage   91.83%   91.77%   -0.06%     
==========================================
  Files          18       18              
  Lines         306      304       -2     
==========================================
- Hits          281      279       -2     
  Misses         25       25
Impacted Files Coverage Δ
R/Tuner.R 85.29% <ø> (ø) :arrow_up:
R/Terminator.R 40% <ø> (ø) :arrow_up:
R/TuningInstance.R 90.8% <ø> (-0.21%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb872bb...2a5292b. Read the comment docs.

mb706 commented 4 years ago

Looks fine to me and fixes my issue.

But why not just delete lines 280ff in TuningInstance.R instead of commenting them?

berndbischl commented 4 years ago

sure i can take the lines out