search

mlr-org / mlr3tuning

Hyperparameter optimization package of the mlr3 ecosystem
https://mlr3tuning.mlr-org.com/
GNU Lesser General Public License v3.0
53 stars 5 forks source link

Optimizer to Tuner #248

Closed be-marc closed 4 years ago

be-marc commented 4 years ago

TODO

codecov-commenter commented 4 years ago

Codecov Report

Merging #248 into master will decrease coverage by 0.04%. The diff coverage is 94.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
- Coverage   92.10%   92.05%   -0.05%     
==========================================
  Files          12       13       +1     
  Lines         190      214      +24     
==========================================
+ Hits          175      197      +22     
- Misses         15       17       +2
Impacted Files Coverage Δ
R/Tuner.R 93.54% <93.33%> (-6.46%) :arrow_down:
R/TunerFromOptimizer.R 100.00% <100.00%> (ø)
R/TunerRandomSearch.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b92b009...7518598. Read the comment docs.

be-marc commented 4 years ago

Also GenSA and GridSearch have still to be moved?

I move the other tuners when we agree on this design. Bernd likes it but we are going to discus a few thing tomorrow.

There is a test that checks TunerRandomSearch, right?

TunerRandomSearch is checked by assert_instance_properties() in bbotk. Did you mean this?

berndbischl commented 4 years ago

I am pretty sure we are going to stay with what we have so you can go ahead.

be-marc commented 4 years ago

Closed by #250