mlr-org / mlr3tuning

Hyperparameter optimization package of the mlr3 ecosystem
https://mlr3tuning.mlr-org.com/
GNU Lesser General Public License v3.0
53 stars 5 forks source link

Add check_values to TuningInstance #257

Closed be-marc closed 4 years ago

be-marc commented 4 years ago

Issues

If a graph contains required parameters (unrelated to the learner) and check_values = TRUE, self$domain$assert in bbotk::Objective$eval_many() fails with Missing required parameters

codecov-commenter commented 4 years ago

Codecov Report

Merging #257 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files          14       14           
  Lines         156      156           
=======================================
  Hits          141      141           
  Misses         15       15           
Impacted Files Coverage Δ
R/Tuner.R 100.00% <ø> (ø)
R/ObjectiveTuning.R 100.00% <100.00%> (ø)
R/TuningInstanceMulticrit.R 91.66% <100.00%> (ø)
R/TuningInstanceSingleCrit.R 93.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2de8728...b4c356f. Read the comment docs.