Closed tdhock closed 4 months ago
Hey, sorry for trouble. Please use tnr("grid_search")
instead of constructing with TunerBatchGridSearch$new()
. Of course we ran a revdep check, but mlr3resampling was not shown. The revdep check made by CRAN did not find the problem either.
I did find it in the logs. Sorry, I overlooked it. There were a few more packages that were broken.
ok thanks
hi, I have been using mlr3tuning::TunerGridSearch in a package vignette which is now failing to re-build CRAN checks, https://cran.r-project.org/web/checks/check_results_mlr3resampling.html
In a previous version of mlr3tuning I got the following
but now I am getting the following
After looking at the new objects available, I guess the solution is to use
mlr3tuning::TunerBatchGridSearch
instead?For future updates like this, it would be great if you could do revdep checks, and notify people like me about what changes we should make in our CRAN packages. I see "BREAKING CHANGE: The Tuner class is TunerBatch now" in https://github.com/mlr-org/mlr3tuning/blob/main/NEWS.md#mlr3tuning-100 but it was not obvious what I needed to do to change my package to be compatible. A more useful NEWS item would be: "Sub-classes of Tuner, such as TunerGridSearch, are now called TunerBatchGridSearch"
Thanks