mmatl / urdfpy

Python parser for URDFs
http://urdfpy.readthedocs.io/
MIT License
246 stars 98 forks source link

Networkx should not be fixed to 2.2 in the setup.py #27

Open Daniella1 opened 2 years ago

Daniella1 commented 2 years ago

When installing urdfpy using pip, (I tried both from pypi and cloning the repo), an error occurs when loading and showing a URDF file. I ran the code:

import urdfpy

robot = urdfpy.URDf.load("ur5e/ur5e.urdf")
robot.show()

And received the error:

ImportError: cannot import name 'gcd' from 'fractions'

It seems the issue that the setup.py file requires that networkx==2.2, but that version doesn't support the functions used in the library, and therefore needs to be upgraded after installing the library. I believe the networkx version requirement can be removed from the setup.py file. (This was tested with Python version 3.9.12 and version 3.10.6 with same results)

adamconkey commented 1 year ago

I also had problems with this, to the point I couldn't even do import networkx, it would immediately give an error with something like AttributeError: module 'numpy' has no attribute 'int'. I got around it by doing pip install --upgrade networkx after everything else installed and it fixed the problem. I get an ugly pip warning saying it's now incompatible with urdfpy though, so it'd be nice to remove that hard version dependency.

michael-projectx commented 1 year ago

Similar problems here as well.