search

mmh352 / ou-container-builder

0 stars 2 forks source link

Scripts configuration #16

Closed mmh352 closed 3 years ago

mmh352 commented 3 years ago

With the scripts section:

scripts:
  - inline:
    - wget --no-check-certificate https://github.com/OpenRefine/OpenRefine/releases/download/3.3/openrefine-linux-3.3.tar.gz
    - mkdir /var/openrefine
    - tar -xzf openrefine-linux-3.3.tar.gz --directory /var/openrefine
    - rm openrefine-linux-3.3.tar.gz

does this get sent to a single layer (I haven't checked in the generated Dockerfile)?

What's the rationale for one line per command? Clarity?

Originally posted by @psychemedia in https://github.com/mmh352/ou-container-builder/issues/11#issuecomment-832073779

mmh352 commented 3 years ago

Yes, this gets sent as a single layer. Having one command per line is more readable, but it will also work if all commands are given in a single line separated by "&&".

psychemedia commented 3 years ago

Presumably the order is respected? (I'm pretty sure it is, just trying to air and raise any possible confusion, bad assumptions etc).

mmh352 commented 3 years ago

Yes. The order is respected.