search

mmh352 / ou-container-builder

0 stars 2 forks source link

Variables in build scripts #18

Closed mmh352 closed 3 years ago

mmh352 commented 3 years ago

Just in passing, I also note that in my original Dockerfiles, the version (3.3) was assigned to a VERSION variable and referenced as such. Again, the current config does not support that, but I know from experience that if you leave version numbers in paths as literals, when you update a version it's all too easy to miss one!

Originally posted by @psychemedia in https://github.com/mmh352/ou-container-builder/issues/11#issuecomment-832075036

mmh352 commented 3 years ago

Variables within an inline script will work. Variables within the ContainerConfig file currently don't work. It is an interesting suggestion. I think I would need to see a concrete example where that is needed.

The ideal safety net is of course to have some automated testing of the container.

psychemedia commented 3 years ago

Re: variables, another useful variable may something along the lines of the Jupyter official stack convention of $NB_USER, as discussed more in https://github.com/mmh352/ou-container-builder/issues/19.