search

mneuhaus / Sick-Beard

Fork to work on multiple Languages in the branch multi_language
http://code.google.com/p/sickbeard/
GNU General Public License v3.0
4 stars 0 forks source link

Work in progress #1

Open an0Nym0us63 opened 12 years ago

an0Nym0us63 commented 12 years ago

Continuation of the discussion

mneuhaus commented 12 years ago

continued discussion from:

https://github.com/LeovR/Sick-Beard/pull/3

an0Nym0us63 commented 12 years ago

I just have to understand how to fork it on my post and pull request modifications (that would be more simple than pasting pieces of code everywhere

mneuhaus commented 12 years ago

np, i hope you're familiar with the terminal/command line

  1. create a fork of sick-beard and clone it to your machine
  2. add my repository to your fork to easily pull my changes:
cd Sick-Beard
git remote add mneuhaus https://github.com/mneuhaus/Sick-Beard.git
  1. get my multi_language branch:
git checkout -b multi_language mneuhaus/multi_language
  1. make your changes and commit them to that multi_language branch and push it to your origin/multi_language
  2. Make a pull-request: https://help.github.com/articles/using-pull-requests

Hope this helps :)

an0Nym0us63 commented 12 years ago

yes  i'm familiar with the terminal command/line   I will start this tonight   Hope having this soon ;)

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 11h48 Objet : Re: [Sick-Beard] Work in progress (#1)

np, i hope you're familiar with the terminal/command line

  1. create a fork of sick-beard and clone it to your machine
  2. add my repository to your fork to easily pull my changes: cd Sick-Beard git remote add mneuhaus https://github.com/mneuhaus/Sick-Beard.git
  3. get my multi_language branch: git checkout -b multi_language mneuhaus/multi_language
  4. make your changes and commit them to that multi_language branch and push it to your origin/multi_language
  5. Make a pull-request: https://help.github.com/articles/using-pull-requests Hope this helps :) — Reply to this email directly or view it on GitHub.
an0Nym0us63 commented 12 years ago

i just started watchnig but i will probably wait you finish commiting everything because , i noticed a mistake in th db, for th show table there is a missing 's' a t audio_lang

mneuhaus commented 12 years ago

yea, i've just started to continue were i left of :)

mneuhaus commented 12 years ago

getting rid of audio_lang in favor of audio_langs right now :)

an0Nym0us63 commented 12 years ago

s let's be sure the working branch is Foreignlanguages

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h10 Objet : Re: [Sick-Beard] Work in progress (#1)

getting rid of audio_lang in favor of audio_langs right now :) — Reply to this email directly or view it on GitHub.

mneuhaus commented 12 years ago

i'm not working on the branch foreignLanguages anymore, because i've taken the current midgetspy/development branch and applied all changes from foreignLanguages in one single commit. This will make it way easier to create a pull request back to midgetspy later on, because the foreignlanguage branch is already to "old" with some commits here and there.

here's the branch i've just pushed:

https://github.com/mneuhaus/Sick-Beard/tree/multi_language

mneuhaus commented 12 years ago

now i'll take a stab at setting the snatched language

mneuhaus commented 12 years ago

if you like you could test german and french a bit :)

an0Nym0us63 commented 12 years ago

I'm preparing everything, i created the fork. I'm going to give it a full test this evening after dinner

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h20 Objet : Re: [Sick-Beard] Work in progress (#1)

if you like you could test german and french a bit :) — Reply to this email directly or view it on GitHub.

an0Nym0us63 commented 12 years ago

did'nt you forget to commit addshowtmpl  because i cant see audio lang selector

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h20 Objet : Re: [Sick-Beard] Work in progress (#1)

if you like you could test german and french a bit :) — Reply to this email directly or view it on GitHub.

mneuhaus commented 12 years ago

nope i didn't forget, i mentioned it in the commit message's TODO, that that's missing. i'll update that after i get setting snatched languages working, which could be quite soon. I've already got a field for the episodes and it gets set to the episodes language when it's snatched. now i'm adding the column to display the language :)

an0Nym0us63 commented 12 years ago

i mean the newshow tmpl

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h20 Objet : Re: [Sick-Beard] Work in progress (#1)

if you like you could test german and french a bit :) — Reply to this email directly or view it on GitHub.

an0Nym0us63 commented 12 years ago

you're right i've just seen your commit message.

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h41 Objet : Re: [Sick-Beard] Work in progress (#1)

nope i didn't forget, i mentioned it in the commit message's TODO, that that's missing. i'll update that after i get setting snatched languages working, which could be quite soon. I've already got a field for the episodes and it gets set to the episodes language when it's snatched. now i'm adding the column to display the language :) — Reply to this email directly or view it on GitHub.

mneuhaus commented 12 years ago

here's a teaser for the episode languages :)

http://snappy-app.com/s/show.php?pass=6f63a387276a1d71c47cded211ca2e7b

an0Nym0us63 commented 12 years ago

I think youre my king youre so fast,  rhaaaa if only i were a better coder lol , i loose a lot of time on my side when i wanted to do something to find how to.

I think i will only help you with my ideas my tests my little modifications maybe) and my congratulations

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h45 Objet : Re: [Sick-Beard] Work in progress (#1)

here's a teaser for the episode languages :) http://snappy-app.com/s/show.php?pass=6f63a387276a1d71c47cded211ca2e7b — Reply to this email directly or view it on GitHub.

an0Nym0us63 commented 12 years ago

what does the both flags mean, should'nt it snatch only preferrred language

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h45 Objet : Re: [Sick-Beard] Work in progress (#1)

here's a teaser for the episode languages :) http://snappy-app.com/s/show.php?pass=6f63a387276a1d71c47cded211ca2e7b — Reply to this email directly or view it on GitHub.

an0Nym0us63 commented 12 years ago

i'm not able to test for now because i have a bug

when i had a existing show or a new show

Traceback (most recent call last): File "D:\Github\Sick-Beard\cherrypy_cprequest.py", line 660, in respond response.body = self.handler() File "D:\Github\Sick-Beard\cherrypy\lib\encoding.py", line 193, in call self.body = self.oldhandler(_args, _kwargs) File "D:\Github\Sick-Beard\cherrypy_cpdispatch.py", line 25, in call return self.callable(_self.args, _self.kwargs) File "D:\Github\Sick-Beard\sickbeard\webserve.py", line 1953, in index return _munge(t) File "D:\Github\Sick-Beard\sickbeard\webserve.py", line 120, in _munge return unicode(string).encode('utf-8', 'xmlcharrefreplace') File "C:\Python27\lib\site-packages\Cheetah\Template.py", line 1010, in unicode return getattr(self, mainMethName)() File "_Github_Sick_Beard_data_interfaces_default_home_tmpl.py", line 339, in respond File "C:\Python27\lib\site-packages\Cheetah\NameMapper.py", line 245, in valueFromSearchList executeCallables=executeCallables) File "C:\Python27\lib\site-packages\Cheetah\NameMapper.py", line 229, in _valueForName obj = nextObj() File "D:\Github\Sick-Beard\sickbeard\tv.py", line 130, in getLanguagesList for language in self.getLanguages(): File "D:\Github\Sick-Beard\sickbeard\tv.py", line 114, in getLanguages for language in self.audio_langs.split("|"): AttributeError: 'NoneType' object has no attribute 'split'

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h45 Objet : Re: [Sick-Beard] Work in progress (#1)

here's a teaser for the episode languages :) http://snappy-app.com/s/show.php?pass=6f63a387276a1d71c47cded211ca2e7b — Reply to this email directly or view it on GitHub.

mneuhaus commented 12 years ago

Those are the languages of the snatched downloads. Newzbin provides multiple languages :-) Am 24.08.2012 18:49 schrieb "sarakha63" notifications@github.com:

what does the both flags mean, should'nt it snatch only preferrred language

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h45 Objet : Re: [Sick-Beard] Work in progress (#1)

here's a teaser for the episode languages :) http://snappy-app.com/s/show.php?pass=6f63a387276a1d71c47cded211ca2e7b — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008072.

LeovR commented 12 years ago

So those are the languages for one file, right? (Dubbed) Or do you snatch multiple files?

an0Nym0us63 commented 12 years ago

You mean it snatched an episode with both language i tought it snatched an episode for both language (strange for a sd-tv to have two soundtracks)

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 19h12 Objet : Re: [Sick-Beard] Work in progress (#1)

Those are the languages of the snatched downloads. Newzbin provides multiple languages :-) Am 24.08.2012 18:49 schrieb "sarakha63" notifications@github.com:

what does the both flags mean, should'nt it snatch only preferrred language

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h45 Objet : Re: [Sick-Beard] Work in progress (#1)

here's a teaser for the episode languages :) http://snappy-app.com/s/show.php?pass=6f63a387276a1d71c47cded211ca2e7b — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008072.

— Reply to this email directly or view it on GitHub.

mneuhaus commented 12 years ago

One file :-) Am 24.08.2012 19:13 schrieb "LeovR" notifications@github.com:

So those are the languages for one file, right? (Dubbed) Or do you snatch multiple files?

— Reply to this email directly or view it on GitHubhttps://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008738.

an0Nym0us63 commented 12 years ago

OK i understand, just a suggestion it is secondary, because some other things are prioritary. But audio languages is too long and makes a big case for only one or two flags  (i suggest :

Soundtracks, Audio Lang. (something less long)

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 19h15 Objet : Re: [Sick-Beard] Work in progress (#1)

One file :-) Am 24.08.2012 19:13 schrieb "LeovR" notifications@github.com:

So those are the languages for one file, right? (Dubbed) Or do you snatch multiple files?

— Reply to this email directly or view it on GitHubhttps://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008738.

— Reply to this email directly or view it on GitHub.

mneuhaus commented 12 years ago

Yes, but it is. Just search for it on Newzbin. Am 24.08.2012 19:14 schrieb "sarakha63" notifications@github.com:

You mean it snatched an episode with both language i tought it snatched an episode for both language (strange for a sd-tv to have two soundtracks)

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 19h12 Objet : Re: [Sick-Beard] Work in progress (#1)

Those are the languages of the snatched downloads. Newzbin provides multiple languages :-) Am 24.08.2012 18:49 schrieb "sarakha63" notifications@github.com:

what does the both flags mean, should'nt it snatch only preferrred language

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h45 Objet : Re: [Sick-Beard] Work in progress (#1)

here's a teaser for the episode languages :) http://snappy-app.com/s/show.php?pass=6f63a387276a1d71c47cded211ca2e7b — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub< https://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008072>.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008760.

mneuhaus commented 12 years ago

I'll commit that later. I'm grocery shopping right now :-) Am 24.08.2012 19:18 schrieb "Marc Neuhaus" mneuhaus@famelo.com:

Yes, but it is. Just search for it on Newzbin. Am 24.08.2012 19:14 schrieb "sarakha63" notifications@github.com:

You mean it snatched an episode with both language i tought it snatched an episode for both language (strange for a sd-tv to have two soundtracks)

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 19h12 Objet : Re: [Sick-Beard] Work in progress (#1)

Those are the languages of the snatched downloads. Newzbin provides multiple languages :-) Am 24.08.2012 18:49 schrieb "sarakha63" notifications@github.com:

what does the both flags mean, should'nt it snatch only preferrred language

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h45 Objet : Re: [Sick-Beard] Work in progress (#1)

here's a teaser for the episode languages :) http://snappy-app.com/s/show.php?pass=6f63a387276a1d71c47cded211ca2e7b — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub< https://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008072>.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008760.

LeovR commented 12 years ago

What about other providers?

an0Nym0us63 commented 12 years ago

No i beleive you and it's great if it's working like that.

When you'll all finish i'll give it a try to an episode wich is in english and then i will creat a report for it in french to see if it catches and replaces it by putting french, english  and checkbox french.

Great work and waouuuwww it's just like you will finish the project in one day lol

I really say it congratulation and i will do alll i can to test, debug and give suggestions

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 19h18 Objet : Re: [Sick-Beard] Work in progress (#1)

Yes, but it is. Just search for it on Newzbin. Am 24.08.2012 19:14 schrieb "sarakha63" notifications@github.com:

You mean it snatched an episode with both language i tought it snatched an episode for both language (strange for a sd-tv to have two soundtracks)

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 19h12 Objet : Re: [Sick-Beard] Work in progress (#1)

Those are the languages of the snatched downloads. Newzbin provides multiple languages :-) Am 24.08.2012 18:49 schrieb "sarakha63" notifications@github.com:

what does the both flags mean, should'nt it snatch only preferrred language

De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 18h45 Objet : Re: [Sick-Beard] Work in progress (#1)

here's a teaser for the episode languages :) http://snappy-app.com/s/show.php?pass=6f63a387276a1d71c47cded211ca2e7b — Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub< https://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008072>.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/mneuhaus/Sick-Beard/issues/1#issuecomment-8008760.

— Reply to this email directly or view it on GitHub.

an0Nym0us63 commented 12 years ago

i think for other providers, it will catch the episode language the same way. if there is one it will catch one if it's multiple language it will catch all laguages if the language you wanted is in the list.It's very rare to have mutliple language show but it's great that when it happens it is implemented. I saw that for movies but rarely for tvshows. But great.

De : LeovR notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Vendredi 24 août 2012 19h27 Objet : Re: [Sick-Beard] Work in progress (#1)

What about other providers? — Reply to this email directly or view it on GitHub.

mneuhaus commented 12 years ago

i've already changed the other providers to return their single found language as an array, i just think it's the right way to to this because files can have multiple languages :)

the replacing of unsatisfactory languages with an satisfactory language isn't working yet! that's the next part i'll have to tackle, i've only added an column to track the language of the snatched download so far.

but i'll give my best to get that working tonight.

you can test if the downloading itself works so far, and if it correctly recognises the desired language.

an0Nym0us63 commented 12 years ago

Traceback (most recent call last): File "D:\Github\Sick-Beard\cherrypy_cprequest.py", line 660, in respond response.body = self.handler() File "D:\Github\Sick-Beard\cherrypy\lib\encoding.py", line 193, in call self.body = self.oldhandler(_args, _kwargs) File "D:\Github\Sick-Beard\cherrypy_cpdispatch.py", line 25, in call return self.callable(_self.args, _self.kwargs) File "D:\Github\Sick-Beard\sickbeard\webserve.py", line 1953, in index return _munge(t) File "D:\Github\Sick-Beard\sickbeard\webserve.py", line 120, in _munge return unicode(string).encode('utf-8', 'xmlcharrefreplace') File "C:\Python27\lib\site-packages\Cheetah\Template.py", line 1010, in unicode return getattr(self, mainMethName)() File "_Github_Sick_Beard_data_interfaces_default_home_tmpl.py", line 339, in respond File "C:\Python27\lib\site-packages\Cheetah\NameMapper.py", line 245, in valueFromSearchList executeCallables=executeCallables) File "C:\Python27\lib\site-packages\Cheetah\NameMapper.py", line 229, in _valueForName obj = nextObj() File "D:\Github\Sick-Beard\sickbeard\tv.py", line 130, in getLanguagesList for language in self.getLanguages(): File "D:\Github\Sick-Beard\sickbeard\tv.py", line 114, in getLanguages for language in self.audio_langs.split("|"): AttributeError: 'NoneType' object has no attribute 'split'

Error i have when adding a show

mneuhaus commented 12 years ago

that error is gone now:)

I've added the language selection to the newShow wizard to the "Customize Options"

I've also commited the Audio flags for Episodes, which get set during snatching.

Next up is the task to replace non satisfactory languages with a satisfactory one :)

an0Nym0us63 commented 12 years ago

i think a bug is left

2012-08-24 23:35:34.547000 SHOWQUEUE-ADD :: DB error: no such column: audio_langs 2012-08-24 23:35:34.557000 SHOWQUEUE-ADD :: Error trying to add show: no such column: audio_langs

Impossible to add a show

an0Nym0us63 commented 12 years ago

in fact the column created in show table is audio_lang and not audio_langs as it should

mneuhaus commented 12 years ago

weird, could you start with a fresh database by deleting/renaming the sickbeard.db ? i think the version numbers were messed up at some point, but it should be fine now

an0Nym0us63 commented 12 years ago

in fact it's me i must be tired i think i did'nt launch the good one lol

I'm launching the new one and ill tell you

mneuhaus commented 12 years ago

yea, sorry, didn't get back to it sooner, but i'll be coding for another 1-2 hours probably :)

an0Nym0us63 commented 12 years ago

ok so it's seems good for adding show

2 suggestions (but i think you planned it) :

mneuhaus commented 12 years ago

yea, the ui right now is just a prototype without much love yet :)

i'll have to look into those saved settings when i'll make that ui better :)

but were getting there pretty quickly in my opinion, what do you think?

an0Nym0us63 commented 12 years ago

oh yes very very quickly

here's a bug while searching :

2012-08-24 23:49:31.033000 SEARCHQUEUE-MANUAL-SEARCH :: Error while searching Newzbin, skipping: unhashable type: 'list'

an0Nym0us63 commented 12 years ago

backlog search works but not the manual search

mneuhaus commented 12 years ago

i've created those two issues as seperate issues to keep better track of that :)

2 + #3

an0Nym0us63 commented 12 years ago

yes know the project is advanced enough to cretate real issue

i have a new one lol

an0Nym0us63 commented 12 years ago

we will keep this issue for discussioon

an0Nym0us63 commented 12 years ago

manual search works with nzbmatrix ;)

an0Nym0us63 commented 12 years ago

the same for nzbsu (newznab)

a question does it actually use the order to snatch an episode or no ?

mneuhaus commented 12 years ago

which order do you mean?

an0Nym0us63 commented 12 years ago

yes sorry imeant order of the language :

I know it doesnt actually keep in mind to keep searchingyour prefered langage if it found english

but when the both are choosen (first french then english does it take the order into account ?)

mneuhaus commented 12 years ago

no it doesn't prioritze/order them yet. but that's the behavior i'll try to archieve