mneuhaus / Sick-Beard

Fork to work on multiple Languages in the branch multi_language
http://code.google.com/p/sickbeard/
GNU General Public License v3.0
4 stars 0 forks source link

Work in progress #1

Open an0Nym0us63 opened 12 years ago

an0Nym0us63 commented 12 years ago

Continuation of the discussion

an0Nym0us63 commented 12 years ago

ok so it's not a bug ;

I'm keeping testing, triyng to see how it beahves on rss search


De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Samedi 25 août 2012 0h12 Objet : Re: [Sick-Beard] Work in progress (#1)

no it doesn't prioritze/order them yet. but that's the behavior i'll try to archieve — Reply to this email directly or view it on GitHub.

mneuhaus commented 12 years ago

thanks for finding all those weak spots! i think together we'll make this rock-solid in no-time :)

an0Nym0us63 commented 12 years ago

I felt so lonely to try to have mine work with my few knowings in python so i know exactly what to test. and i'm so happy to see someone with the knowings doing it so quikly so it's with pleasure i test


De : mneuhaus notifications@github.com À : mneuhaus/Sick-Beard Sick-Beard@noreply.github.com Cc : sarakha63 sarakha_ludovic@yahoo.fr Envoyé le : Samedi 25 août 2012 0h25 Objet : Re: [Sick-Beard] Work in progress (#1)

thanks for finding all those weak spots! i think together we'll make this rock-solid in no-time :) — Reply to this email directly or view it on GitHub.

an0Nym0us63 commented 12 years ago

i'm know going to test the custom search thing but if you did like i did (copiyng what toilal did it should work)

an0Nym0us63 commented 12 years ago

custom search seems to work ok

UNless we have a probem with newznab and the logs with special characgter like that Le trône de fer

And i don't know if ot was like that before but i did a search for LE trône de fer it found nothing (normal)

I added custom search names "Games of throne" and it snatched all the episodes but not two of them i checked and they exists.

So i made a forced backlog and they weren't catched (so i checked the log (the file because the screen is not working) and i noticed it only used his cache it did'nt research on the providers (maybe because it was too early don't know).

So i did a manual search and they were found.

It's strange i never noticed this behaviour before

an0Nym0us63 commented 12 years ago

i confirm the issue of using the cache of the first search instead of doing a real backlog is recuurent

mneuhaus commented 12 years ago

it's always a pleasure to work with python, its such a logical language :)

an0Nym0us63 commented 12 years ago

lol, don't care about that now, it's not always happening.

But i'll try to identify when it does.

I noticed something else strange wich wasn't happening before .

When i select A lot of episodes for backlog it stops randomly after catching 5-7 episodes and have to rebacklog then it restops after 5-7 episodes :

Here's a piece of log

164021 :: Downloading an NZB from newzbin with id 6859067 août-25 01:15:35 INFO SEARCHQUEUE-BACKLOG-164021 :: Saving to D:\Raising Hope - 2x12 - Gambling Again.nzb août-25 01:15:36 DEBUG SEARCHQUEUE-BACKLOG-164021 :: sickbeard.db: INSERT INTO history (action, date, showid, season, episode, quality, resource, provider) VALUES (?,?,?,?,?,?,?,?) with args [102, '20120825011536', 164021, 2, 12, 1, u'Raising Hope - 2x12 - Gambling Again', 'Newzbin'] août-25 01:15:36 DEBUG SEARCHQUEUE-BACKLOG-164021 :: 164021: Saving episode details to database août-25 01:15:36 DEBUG SEARCHQUEUE-BACKLOG-164021 :: STATUS IS 102 août-25 01:15:36 DEBUG SEARCHQUEUE-BACKLOG-164021 :: sickbeard.db: UPDATE tv_episodes SET status = ?, description = ?, airdate = ?, hastbn = ?, file_size = ?, audio_langs = ?, name = ?, tvdbid = ?, location = ?, release_name = ?, hasnfo = ? WHERE season = ? AND showid = ? AND episode = ? with args [102, u"L'addiction au jeu de Burt refait surface quand il d\xe9cide de regagner tout ce qu'il avait pari\xe9 et perdu vingt ans auparavant. Il entra\xeene Jimmy et Virginia dans cette spirale infernale. Par ailleurs, la cr\xe8che pr\xe9pare une pi\xe8ce dans laquelle Hope joue Hillary Clinton...", 734533, False, 0, 'fr', u'Le syst\xe8me parfait', 4241428, '', '', False, 2, 164021, 12] août-25 01:15:36 DEBUG SEARCHQUEUE-BACKLOG-164021 :: pattern: %SN - %Sx%0E - %EN août-25 01:15:36 DEBUG SEARCHQUEUE-BACKLOG-164021 :: Unable to get parse release_group: Unable to parse août-25 01:15:36 DEBUG SEARCHQUEUE-BACKLOG-164021 :: Episode has no release name, replacing it with a generic one: %SN - %Sx%0E - %EN août-25 01:15:36 DEBUG SEARCHQUEUE-BACKLOG-164021 :: found %0E as the ep pattern using (?P[ .-]) ((?:s(?:eason|eries)?\s)?%0?S(?![.]?N)) (.?) (%0?E(?![.]?N)) (?P[ .-]) and replaced it with \g\g<2>\g<3>12\g to result in %SN - %Sx12 - %EN from %SN - %Sx%0E - %EN août-25 01:15:47 DEBUG CP Server Thread-6 :: sickbeard.db: SELECT DISTINCT season FROM tv_episodes WHERE showid = ? ORDER BY season desc with args [164021] août-25 01:15:47 DEBUG CP Server Thread-6 :: sickbeard.db: SELECT * FROM tvepisodes WHERE showid = ? ORDER BY season DESC, episode DESC with args [164021] août-25 01:15:47 DEBUG CP Server Thread-6 :: sickbeard.db: SELECT COUNT() FROM tvepisodes WHERE status IN (4,3276804,204,404,3204,1604,104,804,6) AND season != 0 and episode != 0 AND airdate <= 734740 août-25 01:15:47 DEBUG CP Server Thread-6 :: sickbeard.db: SELECT COUNT() FROM tv_episodes WHERE season != 0 and episode != 0 AND (airdate != 1 OR status IN (4,3276804,204,404,3204,1604,104,804,2,3276802,202,402,3202,1602,102,802,9,3276809,209,409,3209,1609,109,809,6)) AND airdate <= 734740 AND status != 7 août-25 01:15:59 DEBUG CP Server Thread-6 :: sickbeard.db: SELECT DISTINCT season FROM tv_episodes WHERE showid = ? ORDER BY season desc with args [164021] août-25 01:15:59 DEBUG CP Server Thread-6 :: sickbeard.db: SELECT * FROM tv_episode

you can see the last episode snatched then it goes doing something else

an0Nym0us63 commented 12 years ago

but don't care about this two last things i will investigate to see when exactly it does that

mneuhaus commented 12 years ago

that's weird. i'm currently walking my way through the backlog process to keep looking for other languages when i'm done with that i'll have a better understanding of the backlog process to check what's going on there :)

could also be that, that's a bug of migetspy's current dev branch which i pull earlier :)

an0Nym0us63 commented 12 years ago

ok but i just have done a same backlog and it went trough. I'll see

I think there is something like last backlog time (i did a tweak for that in my installation i think (a long ago) to let me do daily rss search and force it to update cache even if the last time was a minute ago

mneuhaus commented 12 years ago

do you have icq? mine is 73386878

an0Nym0us63 commented 12 years ago

nope sorry but i can try to install it for next time

mneuhaus commented 12 years ago

no problem, we can keep going here as well :)

an0Nym0us63 commented 12 years ago

i think i have finished testing, i didn't test post processing as i used a blackhole but i don't think you changed something

an0Nym0us63 commented 12 years ago

ahhh i found my first episode snatched without updating the audio

an0Nym0us63 commented 12 years ago

mneuhaus commented 12 years ago

looking good eh? :D

an0Nym0us63 commented 12 years ago

globally it's reallly looking good, the bug and sugestion i found will be some little trick for you.

I like people rect as you react and beeing so efficient

an0Nym0us63 commented 12 years ago

jus try luther season 2 episode 1 and 2 in french and enlish with nzbmatrix to see if you have the same result as me if you can

an0Nym0us63 commented 12 years ago

in fact it does that for every nzbmatrix for luther

mneuhaus commented 12 years ago

he just fetched some without language from nzbmatrix :/

mneuhaus commented 12 years ago

i think i'll concentrate on the backlog first ;)

an0Nym0us63 commented 12 years ago

yes of course, ill create an issue

an0Nym0us63 commented 12 years ago

I think with your efficiency and my tests we will have something perfect at the end ;)

mneuhaus commented 12 years ago

i guess we should have an option "Unknown Language" to let the user decide if he wants unknown languages or just "verified" languages

an0Nym0us63 commented 12 years ago

why not this would be even more perfect, but i think no on will take the risk of letting unknown language (even if im sure that unknown will be 90% english)

mneuhaus commented 12 years ago

i think many would use it as the least priority option if everything else fails. Since our goal is to prioritize the languages in the configured order you could say: german:satisfied, english, unknown

an0Nym0us63 commented 12 years ago

yes like that it would not be a bad idea .. (as we have the audio icon in the episode to know how it was catched)

I would rather say french : satisfied , english , unknown lol

an0Nym0us63 commented 12 years ago

just installed icq

LeovR commented 12 years ago

Just wanted to let you guys know that I'm not completely out of the game but it seems that both of you have way more time for this than me. Nevertheless, the good thing with github is that I'm still able to help but now the other way round with pull-requests to your branch.

an0Nym0us63 commented 12 years ago

Yes your help would be greatly appreciated I think all three we are able to have something very very great

mneuhaus commented 12 years ago

Just thinking out loud:

i've got a show x for which i want the language german to be satisfied, but it should fetch english as long as it can't find a german one.

an0Nym0us63 commented 12 years ago

For me sb should replace with the desired language as this is really what is mandatory for people using foreign language in sb.

For movies it could be different as we have TS screeners cams, but for tvshow this is not the case so langugae should be prioritary

an0Nym0us63 commented 12 years ago

maybe i won't be present tonight but you can commit your change i will give it a lot test tomorrow midday and evening

mneuhaus commented 12 years ago

I've improved/fixed the ui to manage multiple languages:

http://snappy-app.com/s/show.php?pass=86329793469e2806274b8c706564a6a2

an0Nym0us63 commented 12 years ago

Waouwww this has a very professional looking

mneuhaus commented 12 years ago

I'm not fully pleased yet with the result, the checkbox seems kind of confusing and i'm not sure about the order of the different elements yet, but we're getting there :)

mneuhaus commented 12 years ago

I'm kinda looking for a more "concise" word to label that checkbox with, because writing that whole sentence beside that is kind of stupid, but simply writing "satisfied" isn't really clear as well. do you guys have an idea how to call that?

mneuhaus commented 12 years ago

maybe "preferred" or something?

an0Nym0us63 commented 12 years ago

Yes for me "Preferred" is quite clear as it what is used for quality and in couchpotato it's kind a word which is clear.

+1 for preferred

mneuhaus commented 12 years ago

i'll try to add an unit test later to get a more repeatable tests :)

an0Nym0us63 commented 12 years ago

waouw one commit again

mneuhaus commented 12 years ago

:) my goal is to make most of the change unittested. makes it easier to debug and way more probable for midgetspy to pull our changes in later on.

an0Nym0us63 commented 12 years ago

hi,

Do you know where i can simply add in my production sickbeard in my nas, the fact that it shows the language in episodes list. And the ability ti change language manually.

I would love to see that waiting for your BIG BIG release. as some tvshows are getting aired now in english (new seasons are starting) .

I would like to simply add the column in db for episodes and simply make it show in episode view and simply make it update this when snatching an episode.

I 'd like to do that without changing to much things.

mneuhaus commented 12 years ago

Do you mean, you want to "backport" a few things into your nas version?

i'll have to see when i can continue to work on this because i'm off to a customer project next week and have to prepare some things for that. i guess i'll jump back in after that week

an0Nym0us63 commented 12 years ago

yeah, of course so if you could just help me implement the language in the episodes view it woudl be great ( it's working very good in you're version) but, it's not easy to backport it as you changed the way things are done on some things)

But i would just like in my version (waiting for us to finish the whole project) to have the language show in episode views and make it possibly to edit it manually without changing the way things are done for now

mneuhaus commented 12 years ago

most of those changes are in 66481b5169 :) but i haven't done anything to edit that manually yet

an0Nym0us63 commented 12 years ago

yes i checked 66481b5 :) , but unfortunately it is'nt easy to implement in mine, because other things are different ;(

an0Nym0us63 commented 12 years ago

i think implementing the manually edit i will handle it by inspiring with the status update.

But for now i didn't manage anithing with the language episodes as things are so different and all my tests failed