Open an0Nym0us63 opened 12 years ago
i think you need to add this to the mainDB as well to get the column into the table
https://github.com/mneuhaus/Sick-Beard/commit/8a364c30613a2ef37dbd8ff510e49e0a336de181#L4R520
it went into a different commit by mistake.
for the most part you'll probably have to rename "audio_langs" back into the name you've used in your version.
the essential part where it takes the languages from the result and saves them in the episode happens here:
https://github.com/mneuhaus/Sick-Beard/commit/66481b51692622f164cbe7aa6d9e37b04b463dae#L3R134
creating the column in episode view (easy) make a snatched episode update db with language : ;( showing the language of the episode view (easy) once the db is updated
i really don't see where to implement easily the dbupdate with the language ;( (i told you i wasnt a good coder ;)
I saw youre message and try this at midday
The db Update happens in the file sickbeard/search.py on line 134
with curEpObj.lock:
curEpObj.status = Quality.compositeStatus(endStatus, result.quality)
curEpObj.audio_langs = result.audio_langs
curEpObj.saveToDB()
i'm not sure for the update it's enough, i think it's kind a calling a class i don't have , i'm i wrong
hmm, difficult to say where it fails exactly. the "result.audio_langs" gets set inside the providers/generic.py on lines 362 and 283 the languages come from the provider. _get_languages(title, item) function in line 258 and 313
https://github.com/mneuhaus/Sick-Beard/blob/multi_language/sickbeard/providers/generic.py
i have a no attribute audio_langs error
Will it work if iadapt your generic modification
as in mine on the get_language i only pass one language (and you pass a kindda list i think)
what is all the code you added in tv.py for using the self.audiolangs ?
that's used to set the status of an episode to "dirty" if that attribute changed, i've just copy and pasted most of that
ok so not usefull for me thanks
For now im still having audio_langs not updated , still looking
everithing is working fine except the episode audio_langs is never updated
don't really understanf what's hapening
could you make a branch at your repository with the version you're working on and push that? i'll get that working tonight for you ;)
oh yes ,, this would be so kind.
In fact i don't want to do too much modifications as it is working perfect for me (im keeping the big changes when your release will raise)
I just wanted to be more easier for me to have the snatched language in the show list, and manually edit it for the episode i already have (for that last i think with looking at the manually status update i could make it)
im going now to look how to make that branch for you, or you could download my repo
you could just push your current changes to your repo and i'll take a look later
ahh i can't push my changes as im at work now.
The only things i tried were :
-adding audio_langs column in episodes (OK)
i suggest if you look at it (to look my repo) without polluting it with all my tried changes (maybe i missed something)
it's working :)
if you add me as a collobarator to your repository i can push it directly into your repository:
Just did it
Cordialement
Le 29 août 2012 à 16:41, mneuhaus notifications@github.com a écrit :
if you add me as a collobarator to your repository i can push it directly into your repository:
https://github.com/sarakha63/Sickbeard/admin/collaboration
— Reply to this email directly or view it on GitHub.
thank you very much
I will give it atry after work and tell you back
Thanks again.
I will try to get the scroll down to update episode languages and if i make it it would be done for your sickbeard release (even if i'm sure you 'll make it in 5 minutes) lol
i noticed that also for the http and https for newzbin this midday but what i don't understand is why this works in my nas with https and not on windows ;)
did you notice where in the code it fires the update when it changes the status for selected episodes.
I just looked at the code at the office (boring with my work), and in fact not so easy to do i think (without changing lots things)
I tought i would simply in show.tmpl do somethinf like that
show a drop menu with fr,en,de, then fire update at episodes audio_langs for all episode selected with the one selected
thanks for all it seems to wrok good. i will do some more tests.
I noticed a bug and this should be interesting for the project too.
IN mine the rss search works good, and snatches new creaed reports but in this case it doesn't update the language column. any idea????
manual and backlog search does but not rss search
think i found something inetresting line 396 in tvcache.py maybe add the show lang (going to test)
lol d'ont know why it worked but inserted f|r instead of fr
yeeeeeeesss i did it it nows update the audio too with rss search
guess what ?
Congratiulations! :)
did you abandon the project ?
hey,
no i did not abandon this project, as i said, i was in copenhagen the whole last week. i'll continue to work on sb sometime this week ;)
greetz marc
hope the project will advance soon ;)
I'm always here to do some hard tests when you want
Continuation of the discussion