mobbr / mobbr-frontend

The angularjs based frontend app for Mobbr
https://mobbr.com
1 stars 0 forks source link

Simplify button embed recipe on /TASK page #305

Closed patricksavalle closed 9 years ago

patricksavalle commented 9 years ago

@handijk It it possible to combine step 3 and 4?

Like this?

<script type="text/javascript" src="https://mobbr.com/mobbr-button.js"></script>
<script type="text/javascript">
    mobbr.button('https://github.com/mobbr/mobbr-browser-plugin', 'EUR', 'medium');
</script>

Or possible even this?

<script type="text/javascript" src="https://mobbr.com/mobbr-button.js">
    mobbr.button('https://github.com/mobbr/mobbr-browser-plugin', 'EUR', 'medium');
</script>

The script itself has a protected against multiple inclusions already.

And while at it: would be nice if on chosing a currency, the buttons refresh to this currency.

screen shot 2015-05-19 at 17 55 28

davidsemakula commented 9 years ago

@patricksavalle second suggestion is a bad idea

https://developer.mozilla.org/en/docs/Web/HTML/Element/script

If a script element has a src attribute specified, it should not have a script embedded inside its tags.
davidsemakula commented 9 years ago

Check out https://github.com/mobbr/mobbr-frontend/pull/320

patricksavalle commented 9 years ago

We will test this on TEST-WWW.MOBBR.COM this week :)