search

mobify / pikabu

Off-Canvas flyout menu
http://mobify.github.io/pikabu/
MIT License
453 stars 51 forks source link

No longer accidentally setting the viewport's height on orientationchange #10

Closed vmarta closed 11 years ago

vmarta commented 11 years ago

Must add the same class to both sidebars. Otherwise, on orientation change, pikabu.js thinks that you're on a "wide-screen" device (ie. no sidebar is active but the right sidebar is visible).

vmarta commented 11 years ago

On iOS 6.1, this bug does not allow you to scroll down the page right from the get-go, because the orientationchange event fires off on page load and the viewport's height is restricted.

donnielrt commented 11 years ago

Looks good to me :+1: Thanks Vincent!