search

mobify / pikabu

Off-Canvas flyout menu
http://mobify.github.io/pikabu/
MIT License
453 stars 51 forks source link

Scroll locks in Chrome for Android and iOS #28

Open manual63 opened 10 years ago

manual63 commented 10 years ago

At first scroll works fine, but after a few seconds and/or if you scroll back to the top, scrolling gets disabled.

I was even able to lock the scrolling on the Pikabu demo page by scrolling up a down a few times with Chrome on my Android 4.4.2 (Galaxy S4).

I tested this in Safari on iOS and on the Android native browser and it worked fine. Seems to just be an issue on Chrome mobile.

kpeatt commented 10 years ago

@manual63 — Thanks! I'll take a look at this, I don't think we've seen it in our project builds so we may have a fix for it that just hasn't been PRd back into master yet.

geekyMoa commented 10 years ago

@kpeatt Do you have an update on this? Having this issue on Chrome 35 for Android 4.4.4 (Nexus 5).

I noticed the height of the panel(s? I only use one panel) is calculated on scroll, is that the intended behaviour? Could it be related to Chrome firing the resize event on scroll? I seem to run into that annoying issue all the time.

kpeatt commented 10 years ago

@geekyMoa — No update as of yet. We're looking at 2.0 beta sometime this month but I haven't encountered this problem in a build yet.

Have you tried using the development branch and seeing if you still have the issue?

Really sorry you're hitting this bug — definitely want to get it fixed.

Bielousov commented 10 years ago

We had an issue with Galaxy SIII Android 4.3 (but not 4.1) that sounds related. The bug was that after opening and closing Pikabu the viewport appeared locked (no vertical scroll). Also any pikabu:close event wouldn't fire.

The thing is that this device recognizes transitionEnd event though it doesn't really trigger it when CSS animation is finished. Instead it triggers WebkitTransitionEnd event while we are listening for the standard transitionEnd since the device declares that it supports this event.

Check this commit: https://github.com/mobify/pikabu/commit/7ce0d9f9ba964b343a022871151222f2f5a92cce where we fixed the transition end issue for Galaxy S3, it may also help you resolve your bug.