search

mobify / pikabu

Off-Canvas flyout menu
http://mobify.github.io/pikabu/
MIT License
453 stars 51 forks source link

Turn off 'applyPersistentStyles' style injection #34

Closed bluetidepro closed 8 years ago

bluetidepro commented 10 years ago

What is the point of having this.applyPersistentStyles(); (https://github.com/mobify/pikabu/blob/master/src/pikabu.js#L271) in the JS when those same things are also already in the CSS? I don't get why those are in both? It just makes it difficult to override things when it appears in the <head>. Or if anything, could their be an option made to turn off applyPersistentStyles?

kpeatt commented 10 years ago

Hi @bluetidepro — You're very right, we're in the midst of planning a big update to Pikabu over the next little while and I think this is one thing we need to change.

Right now those inline styles are used to have the CSS animations still work even though the widths of the sidebar can be set through the javascript. If you know your sidebar widths, you can get away with getting rid of the inline style block and just relying on the CSS.

If you've got any more questions, please let me know! I'd also love to hear what project you're using this on.

highruned commented 8 years ago

Hi @bluetidepro - Thanks for the report!

We've added an option to turn it off, in the pikabu-1.0 branch.

$('m-pikabu').pikabu({
    useDefaultAnimation: false
});

Please re-open if you still have issues. Cheers and thanks again!