search

mobify / pikabu

Off-Canvas flyout menu
http://mobify.github.io/pikabu/
MIT License
453 stars 51 forks source link

Fix scrollHeight issue? #42

Closed malakada closed 9 years ago

malakada commented 10 years ago

So, this appears to fix the scrollHeight issue I was having in #40, but I'm not 100% sure why. I still get the scrollHeight error message in my console, but it is no longer breaking anything... I can continue to use pikabu without any issue to it or any other operations on the page. Can anyone help me understand why this might work, or if there's anything you see that should be done to make it work even better?

kpeatt commented 10 years ago

Thanks @melissanoelle! We'll check this out.

donnielrt commented 9 years ago

Hey, we’re looking to prune older abandoned PRs. If this PR is still relevant and you would like to see it merged in, please reopen the PR and we’ll add it to our backlog! Thanks!

malakada commented 9 years ago

Nah, I don't really personally care about this for any of my current projects anymore. Maybe again in the future. ;) Thanks.