Handle device orientationchange event

fractaltheory commented 9 years ago

When the device is rotated, the transform applied to .pikabu__container is not updated to reflect this.

Status: Opened for visibility Reviewers: @kpeatt @scalvert

Changes

_buildEvents is updated with a new variable _this, to provide appropriate context for the orientationchange callback function
We check whether pikabu is currently open
Grab .pikabu's width, which is how much we'll be translating .pikabu__container
Apply the new translateX value to .pikabu__container
Notes
Not super happy about applying both transform and -webkit-transform --- open to suggestions there
Currently needed for JTV Mobile, where we're using Pikabu 2.0
Tested only on iOS Sim at the moment

kpeatt commented 9 years ago

Just a note after our IRL conversation re: this bug. The issue is actually that we're setting a width on the main container and translate is working based off that width. This width is wrong on orientation change.

kpeatt commented 9 years ago

So I think this is fixed in the latest version of Pikabu-2.0. Want to give it a shot?

donnielrt commented 8 years ago

Hey, we’re looking to prune older unattended PRs. If this PR is still relevant and you would like to see it merged in, please reopen the PR and we’ll add it to our backlog! Thanks!

mobify / pikabu

Handle device orientationchange event #47

Changes

Notes