mobify / pikabu

Off-Canvas flyout menu
http://mobify.github.io/pikabu/
MIT License
453 stars 51 forks source link

Handle device orientationchange event #47

Closed fractaltheory closed 9 years ago

fractaltheory commented 9 years ago

When the device is rotated, the transform applied to .pikabu__container is not updated to reflect this.

Status: Opened for visibility Reviewers: @kpeatt @scalvert

Changes

kpeatt commented 9 years ago

Just a note after our IRL conversation re: this bug. The issue is actually that we're setting a width on the main container and translate is working based off that width. This width is wrong on orientation change.

kpeatt commented 9 years ago

So I think this is fixed in the latest version of Pikabu-2.0. Want to give it a shot?

donnielrt commented 9 years ago

Hey, we’re looking to prune older unattended PRs. If this PR is still relevant and you would like to see it merged in, please reopen the PR and we’ll add it to our backlog! Thanks!