mobify / pikabu

Off-Canvas flyout menu
http://mobify.github.io/pikabu/
MIT License
453 stars 51 forks source link

Multiple Pikabus should make multiple shades #48

Open kpeatt opened 9 years ago

kpeatt commented 9 years ago

Right now, because shade is instantiated on the Pikabu container and not on the individual Pikabus, you can't have more than one shade. Which means the first shade you instantiate is the only shade you get. Should we allow for multiple shades for each Pikabu on the page? My thought is: yes.

ry5n commented 9 years ago

What’s the use case? The only thing I can think of is to add different styling or animation. That could be enabled with a single shade if that’s easier.

kpeatt commented 9 years ago

@ry5n Currently, the way shade is built, its properties only get passed through on init. So if you want one Pikabu to have a different style of shade than the previous one, you're SOL. If you want it to cover something different or be somewhere else, you're SOL. I think our best bet is to have one per.

ry5n commented 9 years ago

@kpeatt Yup, makes sense.

tedtate commented 5 years ago

We should really fix this.