stop viewport being set at window.innerHeight

[ericawright]

Status: Ready for Review Owner: @ericawright Reviewers: @mikenikles @fractaltheory @jansepar @marlowpayne @stewartyu

Changes

• on Chrome when scrolled down the page the viewport was staying at the top of the page and remained the size of the window.
• remove the body height style, as it was being set to window size
• stop viewport height being set as inner height
• used css to add safari-specific code:
  • chrome browser needs min-height set at 100% -- otherwise we have orientation issues
  • safari browser needs height: 100% -- otherwise orientation and scroll issues

    Todos:

• [x] Engineer +1

  Issues:

https://github.com/mobify/pikabu/issues/66 https://github.com/mobify/pikabu/issues/49

Feedback:

none so far

How to Test

• grunt serve
• go to http://localhost:3000/examples/

[marlowpayne]

Very cool stuff @ericawright ! Just a note that when you touch the src code for Pikabu you'll want to re-build the dist/ files with grunt build and commit them too.

[ericawright]

@marlowpayne thanks, the dist/ files slipped my mind

[mikenikles]

Nice fix, @ericawright! :+1:

[ericawright]

ready to go again after noticing an orientation bug

[fractaltheory]

LGTM! :+1:

There's a test failing but it's failing on develop too so it doesn't block merge -- if you have time @ericawright it'd be awesome to get that fixed too.

[ericawright]

@fractaltheory yup, that test is fixed in https://github.com/mobify/pikabu/pull/76

[fractaltheory]

:100: !