user was unable to add custom classes for appendTo and container options (unless they also used pikabu's built in classes)
$viewport was not being defined when custom classes used
$animators array was missing custom class when .pikabu_container class was not there
Todos:
[ ] Engineer +1
Notes:
was aimed at master branch previously...
How to Test
in pikabu/examples/assets/js/main, add some custom options such as:
container: '.m-pikabu-container', appendTo: '.m-pikabu-viewport',
to the pikabu declarations (make sure to do this to all 4, or else it will look for the default elements which we will remove)
in pikabu/examples/index.html change line 18 <div class="pikabu"> remove "pikabu" and add custom class name: ".m-pikabu-viewport"
also in pikabu/examples/index.html change line 25 <div class="pikabu__container"> remove "pikabu_container" and replace with custom class "m-pikabu-container"
Status: WIP Owner: @ericawright Reviewers: @mikenikles @fractaltheory @jansepar @marlowpayne @stewartyu
Changes
Todos:
Notes:
was aimed at master branch previously...
How to Test
pikabu/examples/assets/js/main, add some custom options such as:container: '.m-pikabu-container', appendTo: '.m-pikabu-viewport',to the pikabu declarations (make sure to do this to all 4, or else it will look for the default elements which we will remove)pikabu/examples/index.htmlchange line 18<div class="pikabu">remove "pikabu" and add custom class name: ".m-pikabu-viewport"pikabu/examples/index.htmlchange line 25<div class="pikabu__container">remove "pikabu_container" and replace with custom class "m-pikabu-container"grunt serve