search

modelica-tools / FMUComplianceChecker

FMI Compliance Checker for validation of FMUs 1.0 and 2.0
BSD 3-Clause "New" or "Revised" License
43 stars 31 forks source link

Improved error messages for structured naming check #11

Open ghost opened 6 years ago

ghost commented 6 years ago

The messages generated by the structured naming check could be more informative. Example of a current message with little information on what is actually wrong:

[ERROR][FMI2XML] Invalid structured ScalarVariable name "Rectifier_r(60)": syntax error, unexpected $undefined, expecting $end.

filip-stenstrom commented 4 years ago

The error message comes from Bison. $undefined typically means that the parsed character is not defined in the grammar. In this particular case it's a bit odd since we do define the parenthesis token.

While it could be improved, I'd say that the grammar for the variable names is typically simple enough that it's not hard to manually find the cause.

An easy fix might be to bump Bison version though.