using `Camera.set_position` with int arguments causes movement to bug out.

moderngl / moderngl-window

A cross platform utility library for ModernGL making window creation and resource loading simple

MIT License

244 stars 57 forks source link

using `Camera.set_position` with int arguments causes movement to bug out. #90

Closed Leterax closed 4 years ago

Leterax commented 4 years ago

Calling self.camera.set_position(0, 5, 0) where self.camera is KeyboardCamera(self.wnd.keys, aspect_ratio=self.wnd.aspect_ratio) causes the movement to break, presumably because a int vector is passed instead of a float vector. However no error is thrown. Would be nice to have the function either convert to float or check the type.

Leterax commented 4 years ago

See https://github.com/moderngl/moderngl-window/pull/91 for a fix

einarf commented 4 years ago

Merged