Mapless Splash Screen - Githubissues

mohamedmansour / hackathon-letsgo.io

letsgo.io - Photo Hack Day 4 project

http://letsgo.io

5 stars 6 forks source link

Mapless Splash Screen #40

Closed jthiller closed 11 years ago

jthiller commented 11 years ago

The page doesn't give me any map until I enter a route.

Screen Shot 2013-04-17 at 8 29 24 PM

Chrome 26, Mac My public IP is 108.235.112.149

jthiller commented 11 years ago

Update: This looks like an IP issue. My location is actually set to the Atlantic Ocean, just off the coast of Africa.

In this screenshot it is the spot where the bird is. Screen Shot 2013-04-17 at 9 13 43 PM

justinormont commented 11 years ago

I got the same.... LetsGoIO Mapless

We should ban photos w/ lat/lng = 0/0, and user locations of 0/0.

mohamedmansour commented 11 years ago

It recently broke. Geolocation broke somehow, hmm.

mohamedmansour commented 11 years ago

Who wiped the geolocation database ...

  node_modules/geoip-lite/README.md                 |   1 -
  node_modules/geoip-lite/data/geoip-city-names.dat | Bin 13115424 -> 0 bytes
  node_modules/geoip-lite/data/geoip-city.dat       | Bin 26932464 -> 0 bytes

Comon guys :( Should we start restricting "master" branch and letting one maintainer deploy it? We should be careful what we remove and delete.

mohamedmansour commented 11 years ago

I am adding back the database files cause it was wiped out from someone doing a git push force.

justinormont commented 11 years ago

What's the best way to revert a commit? Best in terms of least unforeseen consequences?

mohamedmansour commented 11 years ago

"git revert SHA" so it can undo the changes without resetting