search

molgenis / molgenis-tools-emx-downloader

Stand alone tool to download data in EMX format from molgenis servers
GNU Lesser General Public License v3.0
2 stars 8 forks source link

M4349: As data owner I want MOLGENIS to support the FAIR data port API + bugfixes #48

Closed fdlk closed 6 years ago

fdlk commented 6 years ago

Changes in the shared model:

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will increase coverage by 2.13%. The diff coverage is 58.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #48      +/-   ##
============================================
+ Coverage      57.1%   59.23%   +2.13%     
- Complexity      373      437      +64     
============================================
  Files            41       48       +7     
  Lines          1541     1754     +213     
  Branches        173      189      +16     
============================================
+ Hits            880     1039     +159     
- Misses          540      592      +52     
- Partials        121      123       +2
Impacted Files Coverage Δ Complexity Δ
...va/org/molgenis/downloader/api/MolgenisClient.java 100% <ø> (ø) 1 <0> (ø) :arrow_down:
...va/org/molgenis/downloader/emx/MetadataFilter.java 61.9% <ø> (ø) 6 <0> (ø) :arrow_down:
...java/org/molgenis/downloader/api/metadata/Tag.java 75% <ø> (+13.88%) 25 <0> (+5) :arrow_up:
...nis/downloader/emx/FilteredMetadataRepository.java 82.92% <ø> (ø) 16 <0> (ø) :arrow_down:
...genis/downloader/api/metadata/MolgenisVersion.java 57.14% <0%> (-1.4%) 17 <0> (ø)
.../main/java/org/molgenis/downloader/Downloader.java 0% <0%> (-1.34%) 0 <0> (-1)
...downloader/client/MolgenisV4MetadataConverter.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...downloader/client/IncompleteMetadataException.java 0% <0%> (ø) 0 <0> (?)
...in/java/org/molgenis/downloader/emx/EMXClient.java 65.71% <100%> (+1.82%) 4 <0> (ø) :arrow_down:
...s/downloader/emx/serializers/EMXTagSerializer.java 100% <100%> (+72.72%) 4 <0> (+1) :arrow_up:
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5869e6...9bcc598. Read the comment docs.

tommydeboer commented 6 years ago

The error message that you get when specifying a wrong namespace could be a little bit clearer. Now it's:

java.lang.IllegalArgumentException: Not a valid (absolute) IRI: //example.org/it_emx_datatypes_TypeTest/1