search

molgenis / molgenis-tools-emx-downloader

Stand alone tool to download data in EMX format from molgenis servers
GNU Lesser General Public License v3.0
2 stars 8 forks source link

Fix #73 not following refEntity with dataType FILE for attribute type #74

Closed cpavanrun closed 4 years ago

cpavanrun commented 5 years ago

Related to https://github.com/molgenis/molgenis-tools-emx-downloader/issues/73

Successfully build a jar and tested it against our systems.

codecov[bot] commented 5 years ago

Codecov Report

Merging #74 into master will decrease coverage by <.1%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             master     #74     +/-   ##
==========================================
- Coverage        59%   58.9%   -0.1%     
  Complexity      437     437             
==========================================
  Files            48      48             
  Lines          1760    1760             
  Branches        190     190             
==========================================
- Hits           1039    1038      -1     
  Misses          598     598             
- Partials        123     124      +1
Impacted Files Coverage Δ Complexity Δ
...org/molgenis/downloader/api/metadata/DataType.java 90% <0%> (-10%) 15 <3> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b1c8e9c...7a21d95. Read the comment docs.

molgenis-jenkins commented 5 years ago

Can one of the admins verify this patch?