search

molindo / eslint-config-molindo

ESLint config that implements the Molindo styleguide and helps to catch errors.
MIT License
1 stars 2 forks source link

Add `quote-props` #82

Closed amannn closed 11 months ago

amannn commented 2 years ago

"consistent-as-needed" or "as-needed" would probably be a good idea.

https://eslint.org/docs/rules/quote-props

amannn commented 1 year ago

This should be set at the prettier level: https://prettier.io/blog/2019/04/12/1.17.0.html#add-an-option-to-modify-when-prettier-quotes-object-properties-5934-by-azz

amannn commented 1 year ago

Or not, this is a bit strange with aria-label:

type Props = {
  'className'?: string;
  'isOpen'?: boolean;
  onClick(): void;
  'aria-label': string;
  'inverted'?: boolean;
};
amannn commented 11 months ago

Let's leave this out for now, as there are cases where it's not ideal.