mololab / json-translator

jsontt 💡 - AI JSON Translator + other FREE translation modules to translate your json/yaml files into other languages ✅ Check Readme ✌
https://mololab.org/jsontt/npm
MIT License
427 stars 53 forks source link

feature: Add output file name #42

Closed javix64 closed 10 months ago

javix64 commented 10 months ago

After some hours of checking the code and do some "trial-error", finally I can say that it is working.

Please check the files edited and make the appropriate changes.

javix64 commented 10 months ago

Yesterday, I forget to comment: Please check the test that I have edited yesterday, because I did not do much tests before, probably I fake it, but not idea tbh.

I did the test with the option of: '--name', but I did not the test without that option. Today I checked and it was retrieving the name: undefined.es.json. I have fixed with a ternary operator inside the json_file.ts.

Something that probably we need to check:

Please, check it and tell me if I can do it better :smiley: .

ParvinEyvazov commented 10 months ago

hey @javix64, you are the king!

Looks good for now. I will merge it and test it. After a successful test, will publish a new release.

Thank you!

javix64 commented 10 months ago

always glad to help! 😄

ParvinEyvazov commented 7 months ago

Hey @javix64 ,

Finally, I could a time to do a full test. After a bunch of quick fixes, I released your latest changes. Now jsontt v1.9.0 has an --name output name feature.

Thank you for your contribution. 💪