molstar / pdbe-molstar

Molstar PDBe implementation
Apache License 2.0
89 stars 30 forks source link

Drag and Drop of the second PDB file fails on existing PDB render #78

Closed navashiva closed 1 year ago

navashiva commented 1 year ago

Issue While attempting to render the second PDB file through HTML drag and drop functions on the existing PDB file viewer the second PDB file rendering fails. Following is the error message in the web console:- index.js?9b0a:112 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'props') at Object.applySettings (index.js?9b0a:112:1) at PDBeMolstarPlugin.eval (index.js?9b0a:593:1) at step (tslib.es6.js?9ab4:102:1) at Object.eval [as next] (tslib.es6.js?9ab4:83:46) at fulfilled (tslib.es6.js?9ab4:73:43)

Expected Behavior On the drop of the second PDB file on the previous PDB file viewer, the viewer should clean the canvas and render the second PDB file successfully.

Actual Behavior On the drop of the second PDB file on the previous PDB file viewer, the previous PDB file still renders.

Note: For a demonstration of the issue, refer to the following HTML file.

mandarsd commented 1 year ago

Sorry, your expected behavior would not work as the PDBe implementation is not intended to handle drag and drop, and multiple structure files.