search

monashmicroimaging / podocytes

GNU General Public License v3.0
2 stars 3 forks source link

Podo executable icon left in Mac taskbar after Gooey window is closed #6

Closed GenevieveBuckley closed 6 years ago

GenevieveBuckley commented 6 years ago

The Podo executable leaves its icon hanging around in the Mac taskbar (Mac OS High Sierra 10.13.4), even after the program has run to completion and Gooey window has been closed.

It's not causing any problems that I can tell, but it's also not exactly preferred behaviour.

screen shot 2018-05-24 at 9 25 41 am
GenevieveBuckley commented 6 years ago

I did not observe this behaviour with a build using pims, so when this pull I'll close out the issue.

jni commented 6 years ago

Aaaaah I remember now that if you don’t manually kill the VM, the process just hangs when Python tries to exit! Solution: add lifio.done() at the end of the process!

jni commented 6 years ago

Ideally this would be automated via some context manager magic but we can leave that till later. It’s not trivial because you can’t restart the VM once you’ve killed it...

GenevieveBuckley commented 6 years ago

Now that pull https://github.com/monashmicroimaging/podocytes/pull/7 is merged into master, we don't see this behaviour anymore.