monashmicroimaging / podocytes

GNU General Public License v3.0
2 stars 3 forks source link

Use pims (with jpype) instead of python-bioformats and javabridge #7

Closed GenevieveBuckley closed 6 years ago

GenevieveBuckley commented 6 years ago

We should use pims (source code here) for reading in bioformats images, instead of python-bioformats & javabridge.

There are a bunch of advantages over our current situation, in particular:

Note: this pull request is (currently) incompatible with the earlier process-images pull request - the syntax for getting metadata & images from pims vs lifio are different, so I'll need to tidy that up.

This is buildable with pyinstaller, and the program runs to completion (see screenshot below). I'm kind of surprised, because I didn't add any extra webhooks for it. I'm ignoring tifffile's warning, since we're not using it for now.

screen shot 2018-05-25 at 5 42 37 pm
GenevieveBuckley commented 6 years ago

Note that even with a pims build, it appears as if you still need to install the Java legacy SE 6, and the Java Development Kit 10 separately. See issue https://github.com/monashmicroimaging/podocytes/issues/8 for more detailed comment.