search

monero-project / monero-gui

Monero: the secure, private, untraceable cryptocurrency
Other
1.73k stars 767 forks source link

All languages need to be updated for 0.13 - Call for translators #1582

Closed erciccione closed 6 years ago

erciccione commented 6 years ago

Another hard fork is approaching, and with it, a mayor release: 0.13 Since 0.12.3, the GUI changed a bit. Some strings were added and some were removed. #1572 refreshed all language files, so now they can all be updated with the missing translations, before 0.13 is out.

This is a call for translators, down here can be found the list of the available languages. If the language is thicked, somebody worked on it and the translation is already PRd.

If you wish to contribute, please make sure your language is still labelled as 'needed' on the Issue tracker of the Localization Workgroup on Taiga. The task related to this issue is "Update strings (0.13)". If the task is

If you start to work on a language, please write here or let me know using one of the communication channel listed below, so that i can update the issue tracker and avoid double works.

How to translate?

Before starting the translation, we ask you to follow these few guidelines:

A step-by-step guide on how to translate the GUI wallet is available here (the guide is about how to add a new language, but the instructions are also valid for updating one), but, basically, what a translator need to do is:

  1. Look for the correct language file in monero-gui/translations
  2. Find the strings labelled <translation type="unfinished">
  3. Add the correct translation of the <source> string between the <translation> label (removing the type="unfinished"tag)
  4. when done, commit and open a Pull Request with your changes. *Please refer to this issue (#1582) when the PR is opened.

Support

If you need help/informations, or have dubts about the workflow, post on this thread or contact me on these channels:

Ping them all!

Pinging contributors who helped with translations in past and members of the Monero Localization Workgroup:

@3b7ameed @edwardlow @ruzaq @cryptobench @falcongoat @Rafficer @lovvskillz @Keksoj @i3visio @lh1008 @cryptochangements34 @glv2 @assylias @milargos @jonahar @TasmaniaKrama @hrumag @kenshi84 @takuto-h @isaacdigs @ProkhorZ @ElectricSlacks @fridzema @einsteinsfool @szogun1987 @netrik182 @rmbb @ordtrogen @mandrill-pie @fero-sk @jernejml @xmronadaily @alexej996 @snaggen @rtonline @zhizhongzhiwai @Lafudoci @el00ruobuob @Leza89 @turossztrapacska @rpinola @monerorus @kasperaitis @Fajl @TheFuzzStone @IST34 @kerastinell @MalMen

erciccione commented 6 years ago

still pinging them all :P

@4broaf @ni311 @xmoreee @vp1111 @v1docq47 @Re-Diculous @jarole @joli80 @Gelesztaa

bitlamas commented 6 years ago

I have some free time this week and probably the other weekend, pretty sure I can get pt_BR done before 18th October. Count me in :)

el00ruobuob commented 6 years ago

I have started French already. Should be done tomorrow (if I can build easily).

apertamono commented 6 years ago

I want to give other Dutch speakers the opportunity to volunteer, since some Redditors were worried about me doing everything. But I'll be able to translate or review this if nobody else steps up. It's a small update, right? 74 lines in ZH-TW.

erciccione commented 6 years ago

@vp1111 i'm afraid we have much less time than that, if you can, PR as soon as possible, i don't think we have more than a week before tagging

@el00ruobuob always the best :)

@ProkhorZ yes, luckily not too many lines. That's fine, just keep in mind we don't have much time before the release

serhack commented 6 years ago

@erciccione I'm starting Italian.

netrik182 commented 6 years ago

I have some free time this week and probably the other weekend, pretty sure I can get pt_BR done before 18th October. Count me in :)

@vp1111 I'm available to help you on this. Reach me on IRC, same nick, to share the duty.

ElDuderinoBerlin commented 6 years ago

Need german?

erciccione commented 6 years ago

@maddinthegreat somebody already contacted me and should be working on the german translation as we speak. Anyway, i will contact you if i don't heear any update or even just to review it. Thanks :)

@netrik182 Since @vp1111 could start working on the translation only next week, would be great if you could start ASAP and maybe then vp11 can review or help you finish

netrik182 commented 6 years ago

@erciccione sure. I'll do it.

bitlamas commented 6 years ago

@vp1111 i'm afraid we have much less time than that, if you can, PR as soon as possible, i don't think we have more than a week before tagging

Why so little time? The GUI wasn't ready enough to give translators a little bit more time than a couple days? You usually don't want people rushing translations. I also said I would start the translation this week. I will try to get in touch with @netrik182 and see how I can help.

erciccione commented 6 years ago

@vp1111 We definitely have more than a couple of days. The problem is that wasn't clear if the GUI was ready or not, this because an actual code freeze never happened. I waited as much as i could to avoid that potential new parts of the GUI would end up not translated, so at the end i refreshed the language files almost a week ago, but the PR was merged only yesterday. If that's not enough, It's still not clear when we are going to tag the release, that's why i prefer to have all the translations as soon as possible, to have more time for reviews and push as many translations as possible before the tag .

netrik182 commented 6 years ago

Done. Sent new PR on #1590

AbdelhamidGamal commented 6 years ago

All done https://github.com/monero-project/monero-gui/pull/1591

On Wed, Oct 3, 2018 at 1:03 AM netrik182 notifications@github.com wrote:

Done. See PR #1587 https://github.com/monero-project/monero-gui/pull/1587

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/monero-project/monero-gui/issues/1582#issuecomment-426459014, or mute the thread https://github.com/notifications/unsubscribe-auth/AgtlclkMhCD8PF5HZjHAWpjkRq7fuIbtks5ug_DBgaJpZM4XEg4L .

ni311 commented 6 years ago

@ni311 - I will take care in weekend

On Tue, Oct 2, 2018 at 8:33 PM erciccione notifications@github.com wrote:

still pinging them all :P

@4broaf https://github.com/4broaf @ni311 https://github.com/ni311 @xmoreee https://github.com/xmoreee @vp1111 https://github.com/vp1111 @v1docq47 https://github.com/v1docq47 @Re-Diculous https://github.com/Re-Diculous @jarole https://github.com/jarole @joli80 https://github.com/joli80 @Gelesztaa https://github.com/Gelesztaa

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/monero-project/monero-gui/issues/1582#issuecomment-426362725, or mute the thread https://github.com/notifications/unsubscribe-auth/AkpqqiYyohpl-GvcTaame7zfFemIH41qks5ug6N6gaJpZM4XEg4L .

jarole commented 6 years ago

@erciccione I am working on Slovak translation

ghost commented 6 years ago

I can start on the dutch translation tonight if needed

Op di 2 okt. 2018 20:28 schreef ProkhorZ notifications@github.com:

I want to give other Dutch speakers the opportunity to volunteer, but I'll be able to translate or review this if nobody else steps up. It's a small update, right? 74 lines in ZH-TW.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/monero-project/monero-gui/issues/1582#issuecomment-426381524, or mute the thread https://github.com/notifications/unsubscribe-auth/AiFiAmBDGvuUVjjucNsMUP4I4G5zfQmnks5ug7BCgaJpZM4XEg4L .

erciccione commented 6 years ago

@ElectricSlacks It's still needed, thanks :)

apertamono commented 6 years ago

@ElectricSlacks:

I can start on the dutch translation tonight if needed

Great! Could you correct a typo in the existing translation, please? u hersteltekst should be uw hersteltekst.

serhack commented 6 years ago

1584 Waiting for any inputs :)

ghost commented 6 years ago

@ElectricSlacks:

I can start on the dutch translation tonight if needed

Great! Could you correct a typo in the existing translation, please? u hersteltekst should be uw hersteltekst. Done that and some more

1594

apertamono commented 6 years ago

I reviewed the Dutch translation. I'll translate it myself tomorrow, which will be less work than trying to edit this contribution.

takuto-h commented 6 years ago

I'm working on Japanese translation.

turossztrapacska commented 6 years ago

@erciccione I'm working on the hungarian update

Equim-chan commented 6 years ago

@erciccione I'm working on Chinese (Simplified).

apertamono commented 6 years ago

Finished my Dutch translation. I don't have the time to research this now, but it looked like some strings were marked as untranslated while they had been translated before. Maybe with some invisible formatting changes? So it may be worthwhile to search an older version of the translation file, e.g. from May 2018.

AbdelhamidGamal commented 6 years ago

@ProkhorZ found the same thing in Arabic translation

On Fri, Oct 5, 2018, 2:52 AM ProkhorZ notifications@github.com wrote:

Finished my Dutch translation. I don't have the time to research this now, but it looked like some strings were marked as untranslated while they had been translated before. Maybe with some invisible formatting changes? So it may be worthwhile to search an older version of the translation file, e.g. from May 2018.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/monero-project/monero-gui/issues/1582#issuecomment-427213860, or mute the thread https://github.com/notifications/unsubscribe-auth/Agtlcp7zD0MjOvqri6fpq1HLL5YXlND0ks5uhq03gaJpZM4XEg4L .

erciccione commented 6 years ago

some strings were marked as untranslated while they had been translated before.

@ProkhorZ @3b7ameed That's just lupdate. while refreshing the language it happens that some strings get marked as 'unfinished' even if they are finished. Nothing to worry about, it's enough to check if the translation is still valid, and, if that's the case, just remove the label

erciccione commented 6 years ago

+Hacktoberfest

apertamono commented 6 years ago

it's enough to check if the translation is still valid, and, if that's the case, just remove the label

Oh, I should do that before opening it in Qt Linguist next time.

einsteinsfool commented 6 years ago

@erciccione I think they didn't mean the "unfinished" ones. There were some translations that were previously translated but were completely missing from the newest translation files. Some were really long strings. what I did was check the history of my .ts file and copy-paste my old translations.

erciccione commented 6 years ago

There were some translations that were previously translated but were completely missing from the newest translation files

If those strings are missing, it means they are not in the code anymore

what I did was checking the history of my .ts file and copy-pasting my old translations.

This is not a correct workflow, the new strings you added were removed because obsolete. Next tiime, please stick to the refreshed file, without adding and removing anything. Thjis time is not a big deal btw, i will syncronize all the language files again anyway before 0.13 is tagged.

edit: Sorry, i misunderstood what you meant at first. Yes, QT can delete whole translations while lupdating, sadly, there is no way to avoid that

jarole commented 6 years ago

Hi, why do we translate message relating to custom ring size? WARNING: non default ring size, which may harm your privacy. Default of 7 is recommended.

Shouldn't be v0.13 with fixed ring size = 11 ?

erciccione commented 6 years ago

@jarole You are right, but the GUI still give the possibility to use a personalized ringsize. Will signal this to the GUI devs. Thanks :)

Medardas commented 6 years ago

Hey @erciccione , I'll start working on Lithuanian

erciccione commented 6 years ago

GUI 0.13 will be tagged in a couple of days. If you have works still in progress, please PR them before Tuesday

radamihai commented 6 years ago

@erciccione I'm working on Romanian

kasperaitis commented 6 years ago

Lithuanian

Just PR what I updated already.

radamihai commented 6 years ago

@erciccione I'm working on Romanian

Oh, never mind, someone just PRd it

erciccione commented 6 years ago

@radamihai Yes was just PRd, but a review would be appreciated :)

@kasperaitis Seen it, thanks. I'm about to review it, if you have time and want to push some more commits, we have a full day before release.

kasperaitis commented 6 years ago

@radamihai Yes was just PRd, but a review would be appreciated :)

@kasperaitis Seen it, thanks. I'm about to review it, if you have time and want to push some more commits, we have a full day before release.

I'll do my best, but saw that @Medardas started working on Lithuanian language.

erciccione commented 6 years ago

@kasperaitis Yes, i asked him on Taiga to integrate his work with yours. Hopefully he will contact you, but at least now, in the worst case scenario, we have a PR for the Lithuanian language open and technically ready to be merged

alexej996 commented 6 years ago

@erciccione Working on Serbian now.

gorazdko commented 6 years ago

@erciccione i'll do Slovene (Slovenian)

duub commented 6 years ago

Catalan translation is work in progress

enaSo97 commented 6 years ago

@erciccione Working on Korean

geomars commented 6 years ago

@erciccione, I'm working on Indonesian. Done! See PR #1687

erciccione commented 6 years ago

@duub @enaSo97 @geomars Thanks, but keep in mind your translation may not make it for 0.13 Anyway, 0.13.1 should happen soon enough and your works could be included

TheFuzzStone commented 6 years ago

@erciccione, I started work on the Ukrainian translation. I plan to finish tomorrow or the day after.

erciccione commented 6 years ago

GUI 0.13.2 has been tagged. Thanks to all translators and contributors for this huge work :)