moneroexamples / onion-monero-blockchain-explorer

Onion Monero Blockchain Explorer
https://xmrchain.net
BSD 3-Clause "New" or "Revised" License
362 stars 269 forks source link

Display of CLSAG transactions not yet supported #217

Closed rbrunner7 closed 3 years ago

rbrunner7 commented 4 years ago

As per title.

In the list of blocks any block that contains a CLSAG transaction is left out, leading to gaps. And the attempt to directly display the block leads to an internal server error.

Example: https://testnet.xmrchain.net/block/1544011

selsta commented 4 years ago

mooo posted potential fix:


diff --git a/src/tools.cpp b/src/tools.cpp
index ed65f34..2cee2be 100644
--- a/src/tools.cpp
+++ b/src/tools.cpp
@@ -1,4 +1,4 @@
-//
+
 // Created by marcin on 5/11/15.
 //

@@ -937,6 +937,7 @@ decode_ringct(rct::rctSig const& rv,
             case rct::RCTTypeSimple:
             case rct::RCTTypeBulletproof:
             case rct::RCTTypeBulletproof2:
+            case rct::RCTTypeCLSAG:
                 amount = rct::decodeRctSimple(rv,
                                               rct::sk2rct(scalar1),
                                               i,```
selsta commented 4 years ago

Update: CLSAG works fine on my system with latest master, so not sure if this issue is valid.

Edit: https://testnet.xmrchain.net/search?value=b1bd9dd8fdb18bdd7871713fd014f63679c93fa9d93074ce69a00cdbefd0b44d

moneroexamples commented 4 years ago

Thanks. Will check.

moneroexamples commented 3 years ago

Should be solved.