search

moneroexamples / onion-monero-blockchain-explorer

Onion Monero Blockchain Explorer
https://xmrchain.net
BSD 3-Clause "New" or "Revised" License
361 stars 269 forks source link

Hard fork at block 1982800 disabled the explorer #268

Open emesik opened 2 years ago

emesik commented 2 years ago

It seems the HF introducing view tags has disabled the explorer.

emesik commented 2 years ago

I mean the testnet, of course.

moneroexamples commented 2 years ago

Did you use the devel branch of the explorer?

emesik commented 2 years ago

I meant the online version at https://testnet.xmrchain.net/ but perhaps it's not you who runs it?

moneroexamples commented 2 years ago

I'm not running it. Its @Gingeropolous who hosts it. But I will check now how it works on public testnet. So far I've been using private chain.

moneroexamples commented 2 years ago

@emesik Its working on the public testnet. So https://testnet.xmrchain.net/ just needs updating. I will PM @Gingeropolous to have a look.

Thanks for letting me know.

Gingeropolous commented 2 years ago

i updated the explorer, so its running now, but im not seeing tags

j-berman commented 2 years ago

@moneroexamples <00> tags now showing up for outputs that don't have view tags:

00 tag 1

tag 00 2

00 view tags are technically valid view tags, so it's a tad confusing.

Note there's also a grace period where outputs with and without view tags are valid outputs (so it's not as though past block 1982800, all outputs will have view tags)

moneroexamples commented 2 years ago

@j-berman Thanks again. I will probably wrap crypto::view_tag with boost::optional when scanning the outputs.

j-berman commented 2 years ago

Gotta helper function for you :)

moneroexamples commented 2 years ago

@j-berman

Just pushed a fix to the view tags being shown as <00> when there are none.