moneroexamples / onion-monero-blockchain-explorer

Onion Monero Blockchain Explorer
https://xmrchain.net
BSD 3-Clause "New" or "Revised" License
361 stars 269 forks source link

Wrong tx_hash above block 1220517 #303

Closed DaWe35 closed 6 months ago

DaWe35 commented 6 months ago

Hi,

I found a weird issue on my local explorer. Every time I reload http://localhost:8081/block/1220517 or any block above, I get a different, seemingly random tx_hash for the non-coinbase transactions:

image

What is broken?

What is working?

My build:

Do you have any ideas what did I broke? I didn't change anything in the related code. Thank you

moneroexamples commented 6 months ago

Is it only for this one block? Also I don't know what changes have been introduced in the fork of the explorer that you use (i.e. fork of DaWe35). Can you try on the original version of the explorer?

DaWe35 commented 6 months ago

Hi,

Any block above 1220517 contains non-existing seemingly random tx_hashes, so not only this block.

The only difference is the docker-compose.yml: https://github.com/moneroexamples/onion-monero-blockchain-explorer/compare/master...DaWe35:onion-monero-blockchain-explorer:docker-compose-with-prebuilt-docker-image

DaWe35 commented 6 months ago

I can confirm this issue is not present when the blockchain is fully stored, so I opened a PR and removed the flag related to pruning. It is not a full fix and as I can see, the explorer should work with pruned txes.

It's possible that we have a bug in get_pruned_transaction_hash() or somewhere else.