montreyw / Theme-Redesign-and-SEO-Overhaul

Earmilk redesign project
2 stars 0 forks source link

Montrey seems to think there is some issue on tablet sizes #50

Closed andrebu closed 8 years ago

andrebu commented 8 years ago

This image was messaged at me:

I interpret this as something being wrong.This image was messaged at me:This image was messaged at me:

My best guess is that it is not liked that the sidebar stay vertical even when there is space for sidebar items to be horizontally side-by-side on tablet sized screens.

This, however, is not a bug or an error, but in fact a "feature."

The issue is in fact a feature of the sidebar behavior as designed by the theme developers -- that is, the sidebar items are arranged around by Masonry. This is initiated in ``, at line # 317:

    ///////////////////////////////////////    
    // Masonry style for sidebar
    ///////////////////////////////////////    
    jQuery( window ).load( function( $ ) {"use strict"; var $container = jQuery('.sidebar'); $container.imagesLoaded( function(){ $container.masonry({ itemSelector : '' }); });});
andrebu commented 8 years ago

I simply commented out Masonry and the issue si "fixed":

    ///////////////////////////////////////    
    // Masonry style for sidebar
    ///////////////////////////////////////    
/*
    jQuery( window ).load( function( $ ) {
        "use strict"; 
        var $container = jQuery('.sidebar'); 
            $container.imagesLoaded( function(){ 
                $container.masonry({ 
                    itemSelector : '.widget',
                    columnWidth: 700,
                    fitWidth: true
            }); 
        });
    });
*/
screen shot 2016-04-24 at 10 09 00 pm
andrebu commented 8 years ago

Turning off Masonry causes another minor problem. Now, gaps are present like so:

screen shot 2016-04-24 at 10 09 50 pm screen shot 2016-04-24 at 10 09 53 pm

To solve this, someone should install Packery.js or Isotope.js, and either of these will tightly stack the sidebar items to eliminate any gaps (though some empty space may present itself at the bottom of sidebar after all items tightly stacked/packed)