Closed ashmoran closed 8 years ago
Looks good to me! Thanks for the patch! (Cherry-picked to master. Why github doesn't at least give the option to fast forward is beyond me.)
I thought if anyone else got stuck with a different board I could go back and make it read from a list of known good ones. Possibly by this point it's easier to make a list of older boards known to be too slow, but I don't know how different ARM architectures affect the build process. (There are some smoking hot ARM SoC's around these days!)
Sorry if I borked the PR process. I hate git at the best of times, wasn't sure if I should make a new branch and open a pull from that, or whatever other ritual git/GH expects me to do. Normally my attempts to merge my changes in git to another repo resemble the results of combining a curry, a fast moving car, and a brown paper bag.
I'm working on a pure-python port of dashman I hope to release later this year, so don't worry too much about the specifics of this patch.
No, you did fine, exactly what you needed to do. I love git. The issue is the way github's automated tools force a certain workflow (which works well for some cases, but isn't always necessary.)
I decided I wanted to try running Dash on the CuBox-i4x4 computer I bought a while back, but dashman wouldn't install the ARM build on it because it's not a Raspberry Pi 2.
The board in this device identifies itself as:
I've added a hacky patch to trick dashman into installing it. This isn't a scalable system for adding more boards, but it works on my machine!