add moonrun -i

[Yu-zh]

When running moonrun -i, it starts an interactive process. The process reads wasm byte sequence from stdin, executes it, and print the result to stdout.

[peter-jerry-ye-code-review[bot]]

From the provided git diff output, here are three potential issues that could impact the functionality or maintainability of the code:

1. Uninitialized Variable (bytes) in wasm_mode Function:

   • The variable bytes is conditionally defined based on the source type. If source is Source::File, bytes is not initialized until later in the function. However, the script generation logic assumes bytes is always defined, which could lead to runtime errors if bytes is accessed before being set.
   • Suggestion: Ensure bytes is always initialized before being used in the script. For example, initialize bytes with a default value or restructure the script generation to handle cases where bytes might not be immediately available.

2. Untyped String for WASM Bytes in run_interactive Function:

   • The bytes_string is created by formatting each byte as a string, which could lead to issues when parsing these bytes back to their original form in the WASM module. This approach might not accurately represent the byte sequence required for the WASM module.
   • Suggestion: Ensure the byte sequence is correctly formatted and can be reliably parsed back into a WASM-compatible format. Consider using a more robust method for serializing and deserializing the byte array.

3. Global State Mutation in initialize_v8 Function:

   • The initialize_v8 function sets global flags for the V8 engine, which could lead to unintended side effects if called multiple times or if other parts of the application also modify these flags.
   • Suggestion: Encapsulate V8 initialization in a context or ensure these flags are only set once per application lifecycle. Consider using a flag or a singleton pattern to manage the initialization state of V8.

These suggestions aim to improve the robustness and maintainability of the code by addressing potential runtime errors, ensuring data integrity, and managing global state more effectively.