morris / vinyl-ftp

Blazing fast vinyl adapter for FTP
Other
388 stars 31 forks source link

Vinyl FTP keeps creating new connections #53

Open vladaman opened 8 years ago

vladaman commented 8 years ago

Regardless of the connection options the task creates more then 1 connection.

var conn = ftp.create( {
                parallel: 1,
                maxConnections: 1,
                secure: true,
                reload: true,
                secureOptions: { rejectUnauthorized: false },
                log:      gutil.log
        } );

The copy starts and then in the middle of the task I get following error:

... some files have been uploaded already ...
[07:52:38] 'deploy' errored after 27 s
[07:52:38] Error: Unable to make data connection
    at Socket.<anonymous> (----/main/master/node_modules/vinyl-ftp/node_modules/ftp/lib/connection.js:935:10)

Why is new connection created?

morris commented 8 years ago

The tests all pass with parallel=1 and maxConnections=1 on my end - I don't think it's an extra FTP connection that's created here. It's probably just the upload that fails for some reason. Can you paste the complete log?