mortenbra / alexandria-plsql-utils

Oracle PL/SQL Utility Library
778 stars 316 forks source link

Parse Id and ChangeKey as attributes #22

Closed eaolson closed 8 years ago

eaolson commented 8 years ago

Id and ChangeKey are attributes of the item, not text nodes. This should fix issue #21.

mortenbra commented 8 years ago

Looks like the same mistake (using /text() on an @attribute value) has been made (by me!) a couple of other places in the same package, specifically in getfolder and the various create*_item functions.

Would you mind fixing those as well before I merge?

eaolson commented 8 years ago

Sorry to take so long, but I've fixed the other cases I could find where Id was referenced as a node rather than an attribute. I didn't see any other fields that should have been referenced as attributes. I should point out I don't have an Exchange server I can test this on at home, where I do this sort of work. It compiles, though.

mortenbra commented 8 years ago

Great, thanks!