search

mosbth / irc2phpbb

IRC bot, now lives on Discord bur remains its power to visit IRC whenever it wants.
12 stars 16 forks source link

Some unitttest for when APIs fail. #70

Closed Challe-P closed 2 weeks ago

Challe-P commented 2 weeks ago

I promise to do better in the future!

kh31d4r commented 2 weeks ago

I promise to do better in the future!

you can change the message and use force push to update the message

mosbth commented 2 weeks ago

Let me know when its ready to merge.

@kh31d4r can let us know if its best practise to resolve each conversation here, or just say "its fine, we talked about it and agreed what to do".

kh31d4r commented 2 weeks ago

im not sure what is best practice for github workflows. personally, i like to keep the history clean by amending commits, but maybe it's the norm on github to fix comments in separate commits?

mosbth commented 2 weeks ago

I guess that when it comes to a PR, and one are asked to fix something in it. before merge, then it sounds like the content of the PR should be updated. It feels like "all in one place, one prupose".

kh31d4r commented 2 weeks ago

Yes, within the PR for sure. But by adding new commits to the PR or by updating the existing ones?