mosbth / irc2phpbb

IRC bot, now lives on Discord bur remains its power to visit IRC whenever it wants.
12 stars 16 forks source link

Build and deploy pdoc with gitnub action #77

Closed kh31d4r closed 6 days ago

kh31d4r commented 6 days ago

i kept the /pdoc suffix, but maybe it should be removed (or a nicer landing page created for the github-pages page)

kh31d4r commented 6 days ago

not sure why deploy is failing. it was failing with the same error for my own repo, but that was fixed by adding the permissions in the deploy job configuration

mosbth commented 6 days ago

Error: Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable

image

# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
permissions:
  contents: read
  pages: write
  id-token: write

https://stackoverflow.com/a/74167257/341137

kh31d4r commented 6 days ago

yeah, but I have

permissions:
  id-token: write
  pages: write

in the code, and the error is complaining about id-token: write. Which it did on my own repo also, before I added this code.

kh31d4r commented 6 days ago

Adding the read permission didn't help. Any chance you have been tinkering with the security settings for the repo? :)

mosbth commented 6 days ago

Ok, I'll check that later, it might be easier for me to test the deploy action.