motleystate / moonstone

Library to perform Metagenomics data analysis with Python
https://moonstone.readthedocs.io/en/latest/?badge=latest
MIT License
1 stars 0 forks source link

Minor error debugging and some new features #99

Closed AgnesBaud closed 12 months ago

AgnesBaud commented 1 year ago

Description

  1. Error when calling plot_one_graph on GroupBoxGraph class object

ValueError: Invalid value of type 'numpy.int64' received for the 'name' property of box Received value: 11

The 'name' property is a string and must be specified as:
  - A string
  - A number that will be converted to a string
  1. Error when creating SunbeamKraken2Parser object with excel file (extension = .xlsx). Error not encountered with moonstone tests. Maybe because moonstone tests use an older version of pandas (1.0.1 =/= 1.3.5)

    TypeError: read_excel() got an unexpected keyword argument 'sep'`

  2. Metaphlan parser:

# Example: To compute a dataframe only up to the genus level meta2parser = Metaphlan3Parser(input_path, analysis_type='rel_ab', keep_NCBI_tax_col=True) meta2parser.taxonomical_names = meta2parser.taxonomical_names[:-2] # remove "species" and "sTrain" from taxonomical name observed_df = meta2parser.dataframe

Changelogs

Definition of Done

codecov-commenter commented 1 year ago

Codecov Report

Base: 64.65% // Head: 64.65% // No change to project coverage :thumbsup:

Coverage data is based on head (3c8b8dc) compared to base (56db2cf). Patch coverage: 100.00% of modified lines in pull request are covered.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #99 +/- ## ======================================= Coverage 64.65% 64.65% ======================================= Files 61 61 Lines 2872 2872 ======================================= Hits 1857 1857 Misses 1015 1015 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `64.65% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=motleystate#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/motleystate/moonstone/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=motleystate) | Coverage Δ | | |---|---|---| | [moonstone/parsers/base.py](https://codecov.io/gh/motleystate/moonstone/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=motleystate#diff-bW9vbnN0b25lL3BhcnNlcnMvYmFzZS5weQ==) | `79.41% <ø> (ø)` | | | [moonstone/plot/graphs/base.py](https://codecov.io/gh/motleystate/moonstone/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=motleystate#diff-bW9vbnN0b25lL3Bsb3QvZ3JhcGhzL2Jhc2UucHk=) | `87.23% <ø> (ø)` | | | [moonstone/analysis/diversity/base.py](https://codecov.io/gh/motleystate/moonstone/pull/99?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=motleystate#diff-bW9vbnN0b25lL2FuYWx5c2lzL2RpdmVyc2l0eS9iYXNlLnB5) | `81.21% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=motleystate). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=motleystate)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.