search

mottosso / Qt.py

Minimal Python 2 & 3 shim around all Qt bindings - PySide, PySide2, PyQt4 and PyQt5.
MIT License
896 stars 252 forks source link

Updating the `headerToModule` def to only manipulate '.h' files. #402

Closed jasonbrackman closed 3 months ago

jasonbrackman commented 3 months ago

https://github.com/mottosso/Qt.py/issues/401

This is an attempt to have the least amount of impact on the existing functionality, and allow Python custom widgets paths to work.

The original header authored by the user will always be attempted first. If it fails to import for the PySide implementation, a second attempt is made using the original Qt.py headerToModule function.

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

jasonbrackman commented 3 months ago

Will update after installing docker / testing locally.

mottosso commented 3 months ago

Looks good to me. Let me know when you're happy and we can merge this.

jasonbrackman commented 3 months ago

I won't make any other changes if all is good. Thanks!