search

mottosso / Qt.py

Minimal Python 2 & 3 shim around all Qt bindings - PySide, PySide2, PyQt4 and PyQt5.
MIT License
896 stars 252 forks source link

Updated _misplaced_members for PySide6 #405

Closed johnsonthomassonttf closed 1 month ago

johnsonthomassonttf commented 1 month ago

Long time listener, first time caller from The Third Floor

I located these 4 members in PySide6 and based this modification on similar commits. Please let me know if there's a better way to do this. We're actively testing in PySide6 and PySide2, so I may discover more misplaced members.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

mottosso commented 1 month ago

Thanks! Yes, this is the way, except we also need them for PyQt4 and PyQt5. It's hard to miss right now.. And tests won't pick this up.. But if they aren't there, then they simply would not get added to Qt.py when using those.

Could you add these to PyQt4 and 5 as well?

johnsonthomassonttf commented 1 month ago

Added. Also added to PySide. I couldn't find API docs for PyQt4, but I believe it should be a match for PySide 1, so I referenced those API docs. Interesting that they flip-flopped on the location of these members.

mottosso commented 1 month ago

Looks good, thanks @johnsonthomassonttf!