search

mozilla-lockwise / lockwise-ios

Firefox's Lockwise app for iOS
https://mozilla-lockwise.github.io/lockwise-ios/
Mozilla Public License 2.0
245 stars 46 forks source link

autofilll is broken since 1.6.0 #1070

Open heubergen opened 5 years ago

heubergen commented 5 years ago

Steps to reproduce

Install app Login Activate the app as the only autofill service Open a login site (e.g. auth.netatmo.com) with Safari Click on the blue autofill button with your login on it OR Click on the key symbol and then choose the login from the list

Expected behavior

Login information are filled out

Actual behavior

Nothing happens

Device & build information

devinreams commented 5 years ago

@heubergen to help troubleshoot this, can you please confirm if this still doesn't work as expected when you go into the iOS Settings application and disable then re-enable AutoFill (with Lockwise as the selected provider)?

heubergen commented 5 years ago

@devinreams have tried that and it didn't help either. The same results after the reactivation. And I also tried to logout of the app, removing the app and configure it all again.

Edit: If you there's any way for me to test it again with 1.6.0 I can confirm a regression.

andolivieri commented 5 years ago

I can confirm the same behavior:

Device & build information

Device: iPhone SE with iOS 12.3.1 Build version: v1.6.2

yuvalwolf commented 5 years ago

I am unable to reproduce this behavior using the steps above (iPhone X, iOS 12.3.1, app v1.6.2).

natolh commented 5 years ago

Same here with iPhone 5S, iOS 12.3.1 & Lockwise 1.6.2.

cagrist commented 5 years ago

App version: 1.6.2 iOS version: 12.3.1 iPhone 7

Exactly same behavior. It is broken since the app was renamed as Lockwise. It was good before.

heubergen commented 5 years ago

No technical note but just want to load my frustration here: I have no idea if somebody is working on this or not, but I can't understand how in a stable product from Mozilla a core functionality can be broken for >15 days and no one seems to care! I switched the pw manager for now because of this.

dhruvkb commented 5 years ago

I agree wirh @heubergen on this. This feaure is core functionality!

Clicking this button does nothing by dhruvkb Clicking this button does nothing

Choosing Lockwise (2nd option) works by dhruvkb Choosing Lockwise (2nd option) and selecting the same account from the app works.

This has been broken since the rebranding. Please fix this. All other features and bugs can come after the main function of the app works as advertised.

It's been a long time since this issue arose.

joeyg commented 5 years ago

Tried to repo this on my iPhone 7 (12.3.1) and was able to get it into a similar state once by:

  1. Installing the app and enabling Autofill in settings
  2. Locking Lockwise
  3. Opening Settings->Touch ID & Passcode and Disabling "Password AutoFill"
  4. Opening Safari navigating to Github.com When I tap the blue button it does nothing.

I was able to "reset" this by:

  1. Opening Settings->AutoFill Passwords->
  2. Disable Lockwise
  3. Enable Lockwise

Haven't had much luck otherwise. There are two commits that seem like they could be related: https://github.com/mozilla-lockwise/lockwise-ios/commit/f9567116eb6c65d3464e6d905ae3c3d5e96e2a2b#diff-42a9face8036f09d6e628e20be7a5531 https://github.com/mozilla-lockwise/lockwise-ios/commit/a05728f2e301c22ae95fdc2404b4e82620cf4dab#diff-42a9face8036f09d6e628e20be7a5531

dhruvkb commented 5 years ago

I disabled and re-enabled Lockwise, got a message 'Updating AutoFill', disabled iCloud Keychain but after all this, the blue button still won't work.

joeyg commented 5 years ago

@dhruvkb ah. Ok. Thanks for checking that. If you unlock the app by launching Lockwise, set it to a timeout of like 5min in Settings and then try and use the password auto fill in safari does it work? I’m trying to narrow down the code that could be creating the issue.

dhruvkb commented 5 years ago

My lock timeout is set to Never.

simonc commented 5 years ago

Hi. I can confirm this behavior has been happening for weeks. Config: iPhone X, iOS: 12.3.1, App Version 1.6.2

I tried signing out and back in but it had no effect, uninstalling reinstalling had no effect either. My lock timeout is also set to Never.

heubergen commented 5 years ago

@joeyg Just tried that by installing the app fresh and let the lock by 5 minutes. Auto fill is still broken. Hope that helps!

Excited-ccccly commented 5 years ago

Exactly same issue with heubergen. Have tried to re-enable lockwise in autofill settings and keep lockwise not locked, but lockwise still can't fill my password.

iPad Air 2019, iOS 12.3.1, Lockwise 1.6.2

pinchies commented 5 years ago

Very frustrating. I can’t believe this issue not fixed yet. Still broken on iPhone SE, iOS 12.3.1, Lockwise app 1.6.2 ☹️ Tried: Reinstalling Sign out / sign in Changing timeout

ddurst commented 5 years ago

No technical note but just want to load my frustration here: I have no idea if somebody is working on this or not, but I can't understand how in a stable product from Mozilla a core functionality can be broken for >15 days and no one seems to care! I switched the pw manager for now because of this.

It's very difficult to troubleshoot and subsequently fix an issue that isn't reproducible -- simply because we need to be able to recreate the condition that occurs. And so far, we've been unable to reproduce it.

I'm running 1.6.2 on the same iOS version and settings (but on an iPhone 7), and cannot reproduce this either. So we're 1 for 3 on attemptors at all, and joeyg's almost doesn't count because of the contortions required (which aren't present in the OP). We'll keep trying.

heubergen commented 5 years ago

I'm sorry if I was a bit harsh but for me it looked like nobody would take care of it. Maybe assign it to somebody or something like that would've helped.

Sorry that I can't help any further, if there is anything please let me know.

ddurst commented 5 years ago

I was just able to reproduce this once (for what it's worth, @joeyg). Here's what I did (site X for me was airtable):

0?. Disrupt sync by disabling "logins" from FxA sync settings on iOS. Sync appears to start and spins.

Then, having never been to site X on iOS, and having never saved site X's login on desktop...

  1. Lockwise is installed, FxA sync settings on iOS are all disabled.
  2. Save login for site X on desktop.
  3. Wait for sync to succeed, as evidenced by site X appearing in Lockwise (which I left running, fwiw).
  4. Launch Safari, go to site X.
  5. Attempt to use big blue button, nothing happens.
  6. Click on key icon (perhaps impatiently?), and select the top option in the menu (which is the lockwise credential). This works.
  7. Sign out.
  8. Go back to site X's sign-in form.
  9. The big blue button now works.

😕

joeyg commented 5 years ago

@ddurst thanks for the helpful report! This might be different than previous reports as the tapping the First option in the menu did not work for them. They needed to tap the second option which opens the Lockwise UI for it to work.

dhruvkb commented 5 years ago

Neither the big blue button, nor the first option ' for this website -- Lockwise' works for me. Tried reinstalling, disabling and re-enabling sync and also playing around with lock timings.

pinchies commented 5 years ago

Is there anything / anyway I can provide access to my account / device to help with reproducing this? I could do teamviewer to a laptop while streaming my device screen to the laptop?

joeyg commented 5 years ago

I think next steps are to get y’all a build on buddy build with logging. I’ll try and get a branch up with that.

pinchies commented 5 years ago

For what its worth, I had the same issue on a clean install iPhone, so I suspect something about this is account/content related.

simonc commented 5 years ago

That would explain why it's hard to reproduce since it'd be a data issue, not a "conditions" issue. Could the date of creation the account, the version of Firefox in which the logins were saved, the number of saved passwords, or something like that have any impact? I'm just throwing ideas up in the air but sometimes… 💡 😁

Good luck in your research, let us know of there's anything we can do ❤️

ddurst commented 5 years ago

Well, I can narrow the scope a bit. In my tests, I used:

pinchies commented 5 years ago

I'm really trying to be polite here, and this is not a personal attack, but I feel that perhaps your team is not giving this issue a high priority.

Here I am, I'm trusting the digital keys to some of my most personal information in my life, to a team who have been unable to properly troubleshoot and resolve a major show stopping bug in their app for well over a month.

What confidence do you think this gives me regarding the strength of your app security? What is going on? Is your team under resourced, are you all volunteers, or are there other higher priorities? The lack of communication is incredibly frustrating from a user perspective.

What do you need from us to help troubleshoot this issue? Is there anything we can do? I'm happy to do whatever I can to help.

I had this issue with the last version of the previous app too, before it was renamed lockwise.

joeyg commented 5 years ago

@pinchies sorry to hear this still isn’t working for you. I haven’t had time in my evenings to figure out what is going on - hopefully someone in the community or someone at Mozilla will have time soon to resolve it.

pinchies commented 5 years ago

I have found that when I click the suggested login details in the autofill popup - nothing happens. However, I have found that when I choose "Lockwise...", and use the selector modal popup to choose the desired account (can be the same one as was suggested) then the correct login details are passed through and filled in.

So this specifically seems to be something wrong with the actions that happen after tapping to select/accept the automatically suggested matching login accounts.

I note that at least for me, this is a different outcome than @dhruvkb had, where neither of the options worked. I previously tried both options and they both didn't work - so I would encourage @dhruvkb to try using the "Lockwise..." option again too.

heubergen commented 5 years ago

@pinchies Thanks for confirming my observation:

It works if you choose in the menu the app (so that it opens) and manually click on the login.

andolivieri commented 5 years ago

Updating iOS from 12.3.1 to 12.4 solved the issue for me. Now the app works as expected.

Device & build information

Device: iPhone SE with iOS 12.4 Build version: v1.6.2

simonc commented 5 years ago

Updating iOS to v12.4 didn't fix the issue for me, sorry 🙁

pinchies commented 5 years ago

Didn't fix it for me either unfortunately.

markengelhardt commented 5 years ago

Thanks for the -ugly- work around- tapping lockwise and finding the login in the lockwise app works for me. this bug is very crippling for me when I am away from my laptop- has any developer been able to reproduce this yet?

blaise-io commented 5 years ago

Lockwise is also broken for me since around the time it was renamed from Lockbox to Lockwise. My experience is consistent with other reports in this thread: tapping the login does not work for me as described here and workaround of opening the app does work as described here.

iOS 12.4 iPhone SE Lockwise 1.6.2

An additional observation that may be useful: I only have this issue in Safari. Lockwise does work in other apps that load a webview.

Update: Disabling, then enabling Lockwise as described here completely fixed the issue for me.

  1. Open Settings -> AutoFill Passwords
  2. Disable Lockwise
  3. Enable Lockwise
pinchies commented 5 years ago

iOS 12.4 iPhone SE Lockwise 1.6.2

pinchies commented 5 years ago

Especially in light of the recent news about security vulnerabilities in iPhones, the apparent inability of the developers to fix this bug gives no confidence regarding the level of security that this app offers. This is not the kind of app where oversights are acceptable. This has been unfixed for over two months now. Is there any progress update or ETA for a fix? To date no one has reached out regarding my offer to help reproduce.

ddurst commented 5 years ago 
* Lockwise _does not_ work in other webview for me

I thought you said previously that it did work for you when you chose Lockwise and selected the login from the modal. If this is not what you mean by "webview," then I'm confused -- but if it is what you mean, then I'm not clear on whether your report matches the OP or not. [I'm not talking about a workaround, rather just defining the issue.]

I understand this is frustrating, and I would encourage you (and everyone here) to refrain from criticism (while not meant as a "personal attack" it certainly can be phrased so that said disclaimer is not necessary). This is on the top of our list for the iOS app in terms of fixes, but our limited resources have been focused on more pressing Android issues.

Considering that this is not easily reproducible, there isn't much more we can do until we can dedicate some time to it, which should be in the next week or so. Your help to reproduce is welcome, and (assuming we remain unable to reproduce it AND can get you a debugging build) we may take you up on that. Watching someone do it, at this point, is not going to be as useful as debugging a device where we can reproduce it.

But I can't give you a concrete ETA on a fix. All I can promise is updates here when we have some.

I've updated the labels recently and marking this explicitly to reflect where it is on our engineering priority list.

pinchies commented 5 years ago

I certainly 100% appreciate that there may be limited resources - it sounds like that is the underlying foundational issue here, which is obviously very difficult to change. This may not be deserving of p1 status, but I would hope that the shortage of time is seen by higher ups. It’s an ambitious project, and being a free app I am not surprised that resources are limited. I’ll try record a video to show the issue, and what works and doesn’t work.

Just getting updates would mean a lot to me. I can’t emphasise enough that I am very grateful for these apps to even exist, and all the care and attention that has been put into them so far.

pinchies commented 5 years ago

https://youtu.be/QildpxuNtGs I hope this demonstrates the issue and the workaround that works.

When I last tested thing, it was not working in in-app webviews (e.g outside of safari) . However after testing now I found some different results, and things do seem to be working (except for safari).

Most in app sign ins are working:

https://youtu.be/QildpxuNtGs

Some other in app sign ins appear to not work - as in the password field is not filled in after tapping Lockwise. But then when you tap in the password field the password is immediately added. This behaviour is observed with the eBay app too.

https://youtu.be/TCig-esU7tk

ddurst commented 5 years ago

Thank you for the video -- that answers all of my questions. This reaffirms my decision to leave the P1 label.

pinchies commented 5 years ago

Would love to know if there is any news on this issue. Thanks.

cagrist commented 5 years ago

I think I have waited enough. Switched to Bitwarden and I am happy now.

pinchies commented 5 years ago

@devinreams Would you please provide an update on the current project status? There has been no commits on iOS for months. 😟

ddurst commented 5 years ago

There have been no commits on iOS for months because we lost our dedicated iOS engineer in June. We fully intend to get iOS engineering back up to speed in Q4, and caught up to its Android analogue.

I don't expect this to be closed in a week, but this will be picked up in the next two weeks. That said, with the difficulty we've had in reproducing this, I can't guarantee that we'll have a solution immediately.

I know that this is less than satisfying to many people, and I'm sorry you've had to wait. Despite what most people probably think, Mozilla is not a large company, and resourcing issues affect a small team like ours significantly (which is why we prioritized this particular hire).

pinchies commented 5 years ago

@ddurst Thank you for the update, that’s much appreciated, and helps me with my planning. Best of luck with finding a new team member.

ddurst commented 5 years ago

(We have a new team member: what I'm saying is that they won't be able to pick this issue up until 10-14 days from now.)

dhruvkb commented 5 years ago

While the issue is quite annoying, it hasn't made the app unusable because the flow still works by choosing Lockwise in the popup. image

Best wishes to the new team member and looking forward to seeing this resolved.

cschultzzz commented 4 years ago

Are there any news on this? Welcome on bord to the new iOS developer. I agree: It really leaves a feeling of missing reliability which is crucial here with LockWise being a tool to handle all my passwords... Fingers crossed there can be a fix soon.

devinreams commented 4 years ago

For those that are still experiencing issues, please be sure to try upgrading to iOS 13.2 first as the release notes claim to include auto fill fixes in third-party apps.