ghost
commented
4 years ago I use Enpass Password Manager, is there going to be support for that as well?
Closed abodea closed 1 year ago
ghost
commented
4 years ago I use Enpass Password Manager, is there going to be support for that as well?
cadeyrn
commented
4 years ago Please also test with Firefox Lockwise. It's not the most popular password manager, but important for other obvious reasons. :)
abodea
commented
4 years ago I use Enpass Password Manager, is there going to be support for that as well?
Hi @SS1113 I will include that one as well, thank you for the recommendation!
abodea
commented
4 years ago Please also test with Firefox Lockwise. It's not the most popular password manager, but important for other obvious reasons. :)
Hi @cadeyrn I was going to include Lockwise too, I'm working on Lockwise too so I test that more often.
hkaancaliskan
commented
4 years ago @abodea #7742
ghost
commented
4 years ago Enpass password manager still doesn't work on all my 4 devices, don't know why it is still marked as working in this issue.
Relevant issue: https://github.com/mozilla-mobile/fenix/issues/10640
abodea
commented
4 years ago I will re-check it @SS1113 and come back with some info, I had no issues with Enpass. Can you please tell me what build are you using? From Play Store I suppose?
ghost
commented
4 years ago I will re-check it @SS1113 and come back with some info, I had no issues with Enpass. Can you please tell me what build are you using? From Play Store I suppose?
Nightly 200706 06:01 it's from the Taskcluster. The build that used to be Firefox Preview but is now Firefox Nightly.
ghost
commented
4 years ago
Nightly 200706 06:01it's from the Taskcluster. The build that used to be Firefox Preview but is now Firefox Nightly.
abodea, I am the reporter of this issue https://github.com/mozilla-mobile/fenix/issues/10640; Enpass Password Manager not working. Please let me know if I can provide you any more information. Thanks. :)
ekager
commented
4 years ago @abodea could we possibly test LastPass (and one other password manager that worked from comment 0 to compare) on the migrated release, beta, and nightly channels?
abodea
commented
4 years ago @abodea could we possibly test LastPass (and one other password manager that worked from comment 0 to compare) on the migrated release, beta, and nightly channels?
Hi, @ekager tomorrow I will start testing those and add the results here!
hkaancaliskan
commented
4 years ago @abodea could we possibly test LastPass (and one other password manager that worked from comment 0 to compare) on the migrated release, beta, and nightly channels?
Hi, @ekager tomorrow I will start testing those and add the results here!
Please don't forget to test #7742 too :)
abodea
commented
4 years ago I re-tested this for more details please check the following:
| App | Browser | Autofill? | Bugs | Comments | GV |
|---|---|---|---|---|---|
| 1Password | Migrated RC (latest) | ✅ | - | - | 79.0.2 |
| 1Password | Latest Beta migration | ✅ | - | - | 80.0.0-beta2 |
| 1Password | Latest Debug (from master) | ✅ | - | - | 81.0a1 |
| 1Password | Brave | ✅ | - | - | N/A |
| 1Password | Chrome | ✅ | - | - | N/A |
| LastPass | Migrated RC (latest) | ❌ | - | - | 79.0.2 |
| LastPass | Latest Beta migration | ❌ | - | - | 80.0.0-beta2 |
| LastPass | Latest Debug (from master) | ❌ | - | - | 81.0a1 |
| LastPass | Brave | ✅ | - | - | N/A |
| LastPass | Chrome | ✅ | - | - | N/A |
Note that for LastPass sometimes the autofill pop up is not even displayed. And when I was able to trigger the autofill pop up from LastPass, the same issue described here https://github.com/mozilla-mobile/fenix/issues/4205 is present in all 3 builds.
Example from latest debug build from master.
Example from Brave.
Lastpass Gif
IMO nothing changed regarding password managers and the issues that are present in the description are still reproducible.
@hakkikaancaliskan note that I tested #7742 https://github.com/mozilla-mobile/fenix/issues/7742#issuecomment-668668127 and I added a comment there. I will investigate more languages once I will have time.
ekager
commented
4 years ago Thanks so much @abodea !
ghost
commented
4 years ago Hi, @abodea I'm facing problems while using autofill using Enpass on my device but the issue description says that there's no problem with it. Is there any workaround that I can use to make it work? Or am I missing something?
The pop-up dialogue seem to be continuously appearing and disappearing just as in the issue description that you linked #10640.
abodea
commented
4 years ago Hi, @abodea I'm facing problems while using autofill using Enpass on my device but the issue description says that there's no problem with it. Is there any workaround that I can use to make it work? Or am I missing something?
The pop-up dialogue seem to be continuously appearing and disappearing just as in the issue description that you linked #10640.
Hi, @FrostedIce339 thank you for your comment. If you check https://github.com/mozilla-mobile/fenix/issues/10640#issuecomment-629135567 my comment I also attached a GIF while I auto-filled with Enpass. Based on that I added the status on my bug description but I still added the bug submitted so we can keep the track of it. I will investigate and try to auto-fill again with Enpass and get back to you. Until then can you please let me know what device and on what build are you trying to reproduce this issue? (please attach a screenshot with about).
abodea
commented
4 years ago | App | Browser | Autofill? | Bugs | Comments | GV |
|---|---|---|---|---|---|
| LastPass | Migrated RC 79.0.4 (latest) | ❌ | https://github.com/mozilla-mobile/fenix/issues/12128 | As described here the LastPass doesn't do anything, there is an error message: "Please scroll the browser window until the website address is visible, then try again." error is displayed | 79 |
| LastPass | Latest Beta migration 81.0.0-beta.1 | ❌ | https://github.com/mozilla-mobile/fenix/issues/12128 | As described here the LastPass doesn't do anything, there is an error message: "Please scroll the browser window until the website address is visible, then try again." error is displayed | 80 |
| LastPass | Latest Nightly | ✅ | - | The autofill pop-up is displayed only when tapping on the LastPass app from the notification bar (for more details please check the attachments below) | 81.0a1 |
NOTE:
Right now the only way to make the LastPass pop-up appear in Fenix is to tap on the LastPass app from the notification bar.
And I was able to do this only when I enabled the Legacy autofill from the LastPass app (this will add the LastPass on the notification bar and after tapping on it the autofill pop-up will be displayed in Fenix Nightly).
I tested with Chrome, Brave, and many other browsers and when I tapped on the username/password field the LastPass appeared without problems.
Below you can see that right after I tapped on the username field in Brave browser, the LastPass pop up was displayed.
Regarding https://github.com/mozilla-mobile/fenix/issues/4205 I couldn't reproduce the issue, I will keep investigating it, but I do have Mozilla accounts saved on my LastPass account and I was able to autofill in the latest Nightly without problems on Twitter/Fb.
jamy015
commented
4 years ago And I was able to do this only when I enabled the Legacy autofill from the LastPass app (this will add the LastPass on the notification bar and after tapping on it the autofill pop-up will be displayed in Fenix Nightly).
Even legacy autofill isn't working for me. The autofill pop-up just doesn't show at all after tapping the LastPass icon in the quick settings drawer.
79.0.5 (Build #2015758619) AC: 48.0.15, 8755ac0cd GV: 79.0.1-20200813192915 AS: 61.0.10
vesta0
commented
4 years ago We are working with LastPass to fix this issue. LastPass has not yet implemented support for the new autofill API but they are working on it. @abodea we should test this again in a month.
tstackhouse
commented
4 years ago LastPass has had support for the Android Oreo auto fill API for quite a long time. My impression was that this was something related to Fenix not properly interacting with that system level API to allow any compatible app to provide autofills...
serovar
commented
4 years ago 1Password does not recognize anymore the websites you are in on Nightly.
kbrosnan
commented
4 years ago It may be as simple as Lastpass is forcing Firefox into their legacy implementation and need to add org.mozilla.firefox, org.mozilla.firefox_beta and org.mozilla.fenix to their modern autofill whitelist. We have talked with them and they are looking into it from their side. Considering there are several other password mangers that work with Firefox and we have not heard any issues from those companies/user it seems reasonable that the problem is on Lastpass to investigate.
liuche
commented
4 years ago Also seeing a user report from #14633 for Keepass, which isn't in this list.
sarumont
commented
3 years ago @kbrosnan Is there any open issue with Lastpass that we could follow / vote for / bug them about? :) Still not working for me, so it appears that they are a bit slow...
tigressine
commented
3 years ago Also would like to follow this thread ^
rugk
commented
3 years ago Also would like to follow this thread ^
You can just click the “Subscribe” button on the right on GitHub. No need to comment… :smiley:
Djfe
commented
3 years ago I planned on posting this on #10640 but since this seems to affect lots of autofill apps and lots of devices (see #10640 and #14633), I'll comment on here instead:
The issue is present in Firefox Beta 86 (beta2) while it was fixed in Nightly 86. Same again: Flickering fixed in Nightly 88, bug still happening beta 1 87.0.0
While flickering is fixed in Nightly, positioning for form inputs is still off (viewport is adjusted left/top position plus zoom level when you click on an <input>, but enpass and other form fill apps get transmitted the wrong position for them, so they render on top of your keyboard app etc.)
I'll upload videos now to showcase this (beta and nightly so you have the comparison).
For some reason flickering never affects nightly, maybe it's due to build settings? It's the most annoying part of this bug. Sure you could use your own proprietary API (better since it works automatically), but it would be nice if this would work on system level like it does for all other apps and browsers.
I'm on Android 10 Havoc OS OnePlus 3T
Djfe
commented
3 years ago Beta:
Nightly:
Click on the images to go to YouTube
The pages I used for testing where: https://www.heise.de/sso/login/ https://qis.fh-aachen.de (particularly bad due to the way Firefox focusses on the input field)
The videos have about 20 fps due to my recording software, but it's enough to see the flickering. You can also see pretty well how the autofill sometimes ends up on top of the input field instead of below (or somewhere completely different). I don't know why autofill didn't work on the "qis" page at all in try 1/3 on beta, that was new to me as well and I got it on video. Try 2 and 3 worked in showing the buggy behavior.
If I click on the autofill, then the screen turns black, but that's due to enpass not giving permission for screenshots.
PS: I'm very sorry for creating this comment twice before it was finished (I pressed Enter instead of STRG+Enter)
paulverbeke
commented
3 years ago I must say that on my end neither Bitwarden nor Dashlane works reliably using Autofill service on: Firefox version 88.1.3 Firefox Beta version 89.0.0-beta.7 I must close and reopen the browser several times until the autofill popup is displayed (if it's even displayed at all).
However these password managers works perfectly using Autofill service on: Chrome version 90.0.4430.210 Firefox Focus version 8.15.3 Firefox Nightly version 90.0a1
I must also concur with @Djfe on the fact that autofill popups are almost always rendered over the input forms, directly or after the fact because Firefox will scroll to the field and the popup doesn't follow the scroll. This behavior happens with both my password managers in all of the mentioned Firefox builds: Firefox version 88.1.3 Firefox Beta version 89.0.0-beta.7 Firefox Nightly version 90.0a1 Firefox Focus version 8.15.3
But in Chrome version 90.0.4430.210, with these password managers, the autofill popups will correctly be rendered below the corresponding field.
(besides why is Dashlane not in the table ?)
Appart from this I must say that you've all done a great work with Fenix. I finally started to recommend Firefox (all the way!) to my relatives 😎💙 ! Thanks !!
Tested on OnePlus 5T, OnePlus 6, OnePlus 8T
paulverbeke
commented
3 years ago It's been several months and a lot of versions and the autofill is still not working reliably.
No matter the version this bug is present in: Firefox Firefox Beta
Not happening in: Chrome Firefox Focus Firefox Nightly
*all downloaded from PlayStore
There's already a lot of issues opened related to this:
Based on all my tests and all the comments I found, and exactly like @Djfe said: We're guessing "that this is caused during the build of beta and release. So it cannot be fixed in Nightly since it's not happening there"
Can the team please acknowledge this problem ? It's been at least a year. I even contacted Firefox Support on Twitter who instructed me to open an issue on this repo ^^'
Djfe
commented
3 years ago I know this doesn't add anything new to the issue, but I'm severely frustrated by now. We feel ignored here :(
Please take a look at this bug
Regards
tigressine
commented
3 years ago I've already switched back to Chrome partially because of this issue (ironically after switching back I started using BitWarden instead of LastPass but that's LastPass's fault)
Udayanithig
commented
3 years ago Yes, it's super annoying. Still, firefox has no fix for this issue. And it forced me to use the Vivaldi browser. 💔
dabat
commented
3 years ago For my part, I am quite puzzled about how these password manager issues have remained unfixed for so long. 😢
this is such a core part of everyday use of a browser application, I cannot understand how this sits at severity 2. I would have expected this to be top priority.
Brave browser works flawlessly (being Chromium-based) and so I have switched to Brave for daily use.
P.S. I will say that I really appreciate the extension support that Firefox has... DarkReader is super helpful in low-light 👍🏻
abodea
commented
3 years ago Hello guys, I will start doing some tests regarding Lastpass, and based on my results, I will try to open a new ticket to LastPass to see if there is something we can do on our side to make it work.
Djfe
commented
3 years ago Hi :) that sounds great. Maybe they have an idea, but this affects all password managers on Android. but only with Firefox release and beta. every(!) other app works just fine. Only Firefox behaves weirdly. for example: keepass is also affected (at least)
Bitwarden managed to produce a workaround only for Firefox afaik.
cadeyrn
commented
3 years ago but this affects all password managers on Android
I cannot confirm that it affects all password managers on Android. I use Firefox Lockwise as password manager and don't have any problems with it, neither in Firefox Nightly nor in the stable release of Firefox.
Udayanithig
commented
3 years ago Nope, most commercial password managers are affected by autofill issues on firefox. Very few of them works on firefox. I use Enpass and it still has auto-fill issues. To my surprise, the Nightly version doesn't have any issues regarding autofill, even on older builds. I'm on Android 10.
paulverbeke
commented
3 years ago Dashlane and Bitwarden both have this issue. The Bitwarden workaround is really not consistent as you have to switch apps several times before the input field can be detected
abodea
commented
3 years ago Hi, @paulverbeke and @Djfe!
Can you please let me know if your problem is regarding LastPass or any other password managers (and let me know about them)?
Thank you, Andrei
paulverbeke
commented
3 years ago Hi @abodea thanks for taking the time to investigate this. So to make this exhaustive I tested everything again, each time enabling the corresponding Autofill Service in my OnePlus 8T Android 11:
They all have Accessibility Services available to use but I didn't enabled it (except for NordPass as it was much needed ^^') as it should work with Autofill Service. And by the way it is working for all of them on Chrome without any fault, any multiples clicks needed, or refresh, or close/open.
I sincerely hope it'll be enough details. Let me know if you need anything else
rugk
commented
3 years ago @paulverbeke AFAIK you can also upload videos on GitHub. Just drag and drop them. Third-party links tend tom get lost and then return 404 at some point of time…
Djfe
commented
3 years ago Hi @abodea,
I'm using enpass right now. OnePlus 3T, Havoc OS (Android 10 Custom Rom)
Beta vs Nightly (Beta flickers and moves the viewport around, Nightly only moves the viewport around) These videos were recorded a couple of months ago, I would need to download them from youtube to reupload them to github. (in-case you are wondering, rugk)
Moving the view port after the click leads to enpass drawing it's tooltip at the wrong coordinates, because Firefox gives enpass the old coordinates of the input field on the screen instead of the new ones after moving the view port. This can even lead to enpass drawing it's tooltip over the keyboard, because Firefox tells enpass that the input field is at the position of the keyboard.
The flickering bug only happens when relying on the Android Auto Fill Framework. If I enable enpass as an accessibility service instead, then there is no flickering. The viewport still moves around though so it's still drawn at the wrong coordinates most of the time.
I also tested lastpass now (for the first time): The autofill variant doesn't show up at all for me (while Chrome works fine) The accessibility framework is working (but again: the viewport in Firefox moves)
Udayanithig
commented
3 years ago To be honest even firefox's "autofill in other apps" not working on firefox release nor beta.
abodea
commented
3 years ago @paulverbeke I've been busy with other tasks. I started testing and I will update here once I move forward.
Bitwarden --> Today I reported this https://github.com/mozilla-mobile/fenix/issues/20987 as I was not able to make the autofill pop-up appear. Started with Bitwarden and I will test all the APPS mentioned in the comments above.
Dashlane --> Note that I had no issues with this, as the Dashlane menu was right above the keyboard so I was able to autofill every time.
Djfe
commented
3 years ago @abodea awesome Pls keep in mind, that most issues we have only surface in beta and release but never in Nightly. (and on updates: when version 93 gets to beta status, then the bug will surface in beta where it never was as 93 nightly)
abodea
commented
3 years ago @abodea awesome Pls keep in mind, that most issues we have only surface in beta and release but never in Nightly. (and on updates: when version 93 gets to beta status, then the bug will surface in beta where it never was as 93 nightly)
Thank you! I will keep this in mind and as time allows will check on the RC and Beta too.
paulverbeke
commented
3 years ago @abodea thank you for your work. Regarding Dashlane, here's another recording, with inline Keyboard Autofill enabled, showing you that the popup is not consistently appearing at first touch on the field
Udayanithig
commented
3 years ago Hi @abodea, The autofill issue is still present on the Firefox 92 release. I have also attached a Dropbox link for reference. Video Link
bonyjose
commented
3 years ago Inline autofill is not consistently working with Bitwarden, problem seems to be appearing in stable and beta builds, nightly seems to be working fine. Tracked in below bug
Notes
This is a follow up with the current situation regarding more password manager apps. Initial bug closed now.
User Story
Dependencies
Most popular password manager apps:
Acceptance Criteria
Below I will update the table once I will move forward with the testing and I will add information regarding what issues need to be fixed/investigated if it will be the case to contact the password manager apps developers.
┆Issue is synchronized with this Jira Task