[User Story] 3rd party password manager apps support

abodea commented 4 years ago

Notes

This is a follow up with the current situation regarding more password manager apps. Initial bug closed now.

User Story

As a user, I want to be able to use the password manager apps.

Dependencies

Acceptance Criteria

[ ] Password manager app can access Fenix
[ ] Fenix fills out logins automatically
[ ] Fenix fills out logins automatically after the password manager app was changed
[ ] Focus app parity

Below I will update the table once I will move forward with the testing and I will add information regarding what issues need to be fixed/investigated if it will be the case to contact the password manager apps developers.

App	Autofill?	Bugs	Comments
My passwords
LastPass		https://github.com/mozilla-mobile/fenix/issues/4205
Password Safe	N/A	-	Note that this is offline storage for accounts, I was able to copy/paste any account in Fenix, works as expected
SafeInCloud	❌	https://github.com/mozilla-mobile/fenix/issues/10621
1Password	✅	-	autofill can be done without problems
Avast Passwords	❌	https://github.com/mozilla-mobile/fenix/issues/10628, https://github.com/mozilla-mobile/fenix/issues/10922
Bitwarden	✅	-	autofill can be done without problems
Lockwise	✅	https://github.com/mozilla-mobile/fenix/issues/9905, https://github.com/mozilla-mobile/fenix/issues/3511	autofill can be done without problems
Enpass	✅	https://github.com/mozilla-mobile/fenix/issues/10640	autofill can be done without problems
Password Keeper (Black Berry)	✅	-	autofill can be done without problems

General bugs
https://github.com/mozilla-mobile/fenix/issues/9854

┆Issue is synchronized with this Jira Task

ghost commented 2 years ago

No difference between nightly or normal versions for me. Bitwarden autofill using the Android Autofill framework is very inconsistent for me in Fenix

Sometimes the pop up to select an account doesn't appear and i have to tap away from the form field and back again ~6 times before it will appear.
If the pop up appears and I tap on it to unlock Bitwarden, after selecting an account, it still doesn't get filled in

Using the old accessibility service method for autofilling (with the notification shade icon) used to work but for other reasons Bitwarden is not letting me enable the accessibility service. Ugh.

Also, we shouldn't need to use the accessibility service. Firefox it the only app I have a problem autofilling in.

hkaancaliskan commented 2 years ago

@JpegXguy devs are working on this issue and found the problem, until it's fixed you can change accessibility.force_disabled to 1 in about:config as a workaround (about:config not accessible on stable)

https://bugzilla.mozilla.org/show_bug.cgi?id=1715549

ghost commented 2 years ago

I was able to get Bitwarden to turn on its accessibility service by reinstalling it. Technically it could stop working again. Let's see how it goes with the official Autofill API though. Interesting Bugzilla thread. I'll keep an eye on it, thanks

Djfe commented 2 years ago

@hkaancaliskan that is great news! ❤️

paulverbeke commented 2 years ago

Yes it is great news indeed for Bitwarden users. That said I came across another problem but with 1Password this time. I read both the tracked bugzilla and the related PR but could not figure out if the fix will also apply to this bug.

When visiting https://mega.nz/login on Fenix stable 93.2.0 and Nightly 95.0a1 I could never succeed in making 1Password working despite it working fine on the same url on DuckDuckGo chromium browser.

Could someone reproduce this or confirm if this is the same kind of bug that'll be solved with the previous PR ?

makotokato commented 2 years ago

When visiting https://mega.nz/login on Fenix stable 93.2.0 and Nightly 95.0a1 I could never succeed in making 1Password working despite it working fine on the same url on DuckDuckGo chromium browser.

I guess another issue. I will file new issue to bugzilla.

makotokato commented 2 years ago

@paulverbeke

I must say that on my end neither Bitwarden nor Dashlane works reliably using Autofill service on: Firefox version 88.1.3 Firefox Beta version 89.0.0-beta.7 I must close and reopen the browser several times until the autofill popup is displayed (if it's even displayed at all).

Do you know contact person of Dashlane? Today when I decode their packages, then I find that they misunderstand compatibility-package like Bitwarden, Keepass2Android and etc. So I would like to contact to them to fix this.

In res/xml-v28/autofill_service_config.xml in their APK.

<compatibility-package android:name="org.mozilla.firefox" android:maxLongVersionCode="\ 10000000000" /> <compatibility-package android:name="org.mozilla.firefox_beta" android:maxLongVersionCode="\ 10000000000" />

paulverbeke commented 2 years ago

@makotokato no I'm sorry you'll have to go through the proper channels

paulverbeke commented 2 years ago

Hi everyone, today on stable 93.2, I tested Bitwarden, Dashlane, 1Password and they all works perfectly and reliably, directly on the first focus, and without any workaround ❤️ thanks a lot for all this teamwork cross project !

I must still note 2 things:

for all 3 of them, once you autofilled a credential then emptied the fields (because it wasn't the credential you wanted), you cannot get any password manager to work until you refreshed the page
Nordpass is still not poping at all with autofill services, but I guess it must be on their side 😋

Dimas-sc commented 2 years ago

No love to Keepass2Android? 😥

soredake commented 2 years ago

Need to wait for new version https://github.com/PhilippC/keepass2android/commit/0564a103e15ad0d3f4fde604bef2b9d00b106a00

Udayanithig commented 2 years ago

Still bitwarden is not working for me, but the inline autofill is consistent but on the other hand, credentials are not filling on the login page.

https://user-images.githubusercontent.com/76005728/140646801-c7c5d39c-6ecd-4d60-8754-8f1b32533348.mp4

paulverbeke commented 2 years ago

@udayanithig According to your capture I'm guessing several things are happening here:

1st, based on the fact that you had to unlock your bitwarden vault on both pages, I suppose you configured bitwarden "Vault Timeout" to "immediately" and "Vault Timeout Action" to "Lock". Personally I have it set on 15min.
2nd, the inline autofill entry "My Vault" that opens bitwarden Fullscreen to allow choosing credentials to autofill (or allow unlocking vault then choosing credential) never worked AFAIK on Firefox Android. The workaround is to have your vault setup to stay unlocked a bit like at least 1 minute, tap "My Vault", unlock the vault, and then go back instead of choosing your credential on this page, then you'll find your credential entry in the inline autofill, tap it and it works

Again, another bug that I don't know where to list: bitwarden or Fenix ? @abodea @makotokato ?

makotokato commented 2 years ago

@Udayanithig I guess that this is same issue as https://bugzilla.mozilla.org/show_bug.cgi?id=1693152. When switching activity to Bitwarden, it doesn't fill username and password well. I will look it.

Udayanithig commented 2 years ago

Thanks @makotokato

ChrisG683 commented 2 years ago

Thank you from me as well! This bug has been plaguing Firefox for Android for what feels like 2 years now, I will celebrate the day we can finally be past this bug haha.

Jwpe commented 2 years ago

I've been having issues with LastPass and Firefox for Android since the release of this new implementation. I've got into the habit of just copying passwords directly from the LastPass app instead of trying to rely on the autofill behaviour. However, I've just tested it again after finding this GitHub issue, and the behaviour is very odd.

It doesn't completely fail, but the LastPass overlay doesn't appear when focussing a password field for the first time. After de-selecting and then focussing the field again, the overlay flickers briefly into sight and then disappears again before any credentials can be selected. Repeating the process of de-selecting and and focussing the password field several times, the same thing happens - the overlay briefly appears and then disappears again. Eventually, I can get the overlay to appear permanently after several repetitions.

If I can make a GIF of this to demonstrate, I'll try to do so. I don't have this issue wth autofill in other Android apps.

tommcc commented 2 years ago

Thanks everyone. I have been following this issue for a while, and have been both a) pleased that implementation has improved but b) can confirm I've been having the exact same "flicker" behavior that @Jwpe perfectly describes (Android 12, LastPass).

rogervn commented 2 years ago

I can also second the exact same behaviour as @Jwpe. I actually gave up on Firefox a while back because of this bug. The reason I'm following this thread is to find out if I can come back sometime in the future.

abodea commented 2 years ago

I've been having issues with LastPass and Firefox for Android since the release of this new implementation. I've got into the habit of just copying passwords directly from the LastPass app instead of trying to rely on the autofill behaviour. However, I've just tested it again after finding this GitHub issue, and the behaviour is very odd.

It doesn't completely fail, but the LastPass overlay doesn't appear when focussing a password field for the first time. After de-selecting and then focussing the field again, the overlay flickers briefly into sight and then disappears again before any credentials can be selected. Repeating the process of de-selecting and focussing the password field several times, the same thing happens - the overlay briefly appears and then disappears again. Eventually, I can get the overlay to appear permanently after several repetitions.

If I can make a GIF of this to demonstrate, I'll try to do so. I don't have this issue with autofill in other Android apps.

Thank you for this message! Sorry for the delayed response but I have been changing my project and I had a lot of work on the iOS side. I just re-tested with my phone for a few websites and it worked very well this time on the latest Nightly build with LastPass.

Do you still have that weird behavior or is it working for you now? Asking because I do some more testing and I will try to talk with the Lastpass CC as they will help us to debug this.

I did some research on the RC build and I noticed that when I tap on the username or password field, there is a small flash of the Lastpass autofill window but it disappears.

After many taps somehow the LastPass autofill-pop-up was displayed.

https://user-images.githubusercontent.com/42831109/144413407-e00d26b7-26ab-4904-b880-b69b52785d78.mp4

Thanks, Andrei

makotokato commented 2 years ago

@abodea As long as I look this screencast, it seems to be same issue as Bitwarden etc that is autofill compat mode... If you use beta, there is workaround (https://github.com/mozilla-mobile/fenix/issues/9773#issuecomment-945004703).

Udayanithig commented 2 years ago

Still bitwarden is not working for me, but the inline autofill is consistent but on the other hand, credentials are not filling on the login page. Screenrecorder-2021-11-07-18-49-25-340.mp4

Finally fixed on Firefox beta 102. 🎉

cpeterso commented 1 year ago

Finally fixed on Firefox beta 102. 🎉

Thanks for testing. In that case, I'll close this bug as fixed. If there are other password manager bugs, please file bug reports in Bugzilla's "Fenix > Privacy" component here:

https://bugzilla.mozilla.org/describecomponents.cgi?product=Fenix

mozilla-mobile / fenix