search

mozilla / aestimia

[Archived] Assessment tool
5 stars 10 forks source link

Queue and history pages should have an explicit sort order #36

Closed toolness closed 11 years ago

toolness commented 11 years ago

Right now I'm just querying the database and I have no idea how the results are being sorted coming out.

It seems to make sense for the queue to show the oldest entries first, since those are the ones that need to be reviewed the most... and FIFO's what a queue is, after all.

On the other hand, it seems to make the most sense to have history show results in reverse-chronological order, since this allows folks to monitor recent activity or go back to a submission that they just reviewed...

Thoughts @iamjessklein , @chloeatplay ?

threeqube commented 11 years ago

Could there be a toggle between FIFO and reverse chronology with default on FIFO?

toolness commented 11 years ago

That would be challenging, given our time frame... However, with pagination (see #22), a user could just skip to the last page and go backwards if they really wanted to see things the other way.

chloeatplay commented 11 years ago

@toolness ok got it- definetely badges that have been waiting longer should be displayed first, so there is no positive feedback loop where the ones waiting the longest keep waiting evem more. There is the questin of what happens with badges that you have already reviewed. In the UX we had those at the end of the queue, under the ones submitted the most recently. Will we keep it that way? Other ideas? The reason I want to keep already reviewed badges is for mentors to be able to cross-reference work when they assess.

toolness commented 11 years ago

Oh, Jess and I were talking about it and it was easier to just have a "history" tab with every badge ever reviewed, which is how it's implemented now... there's just the question of how to sort it.

toolness commented 11 years ago

In 9ad67d3c7d88780937b4dcca000c0c81fbaf1623 I changed it to sort the way I've proposed... you can try it out for yourself at https://secret-ravine-6803.herokuapp.com/ - Though you'll have to create a mentor record for yourself here w/ the API secret lol and then create enough submissions to actually make the thing paginate. Right now it paginates 10 entries per page.

toolness commented 11 years ago

Wellll this sort order feels right, so I am closing this ticket. If we decide it needs to change, we can reopen this issue or file a new one!

iamjessklein commented 11 years ago

:+1: