Review > Can not submit submission unless there is a note

mozilla / aestimia

[Archived] Assessment tool

4 stars 10 forks source link

Review > Can not submit submission unless there is a note #62

Closed megcolek closed 11 years ago

megcolek commented 11 years ago

Won't let me submit unless I have a note for both use cases:

APPROVE

For 13+, check off three criteria, but don't write note, and approve submission; then make sure approved submission reflects checked-off criteria and no written note.

DONT APPROVE

For both +13, don't approve a submission and don't include note; then make sure unapproved submission reflects (few/any) checked-off criteria and no note.

cc: @threeqube

toolness commented 11 years ago

Hmm, by "note" do you mean the response that a mentor fills out when they assess a submission? And are you describing the current behavior of Aestimia, or the desired behavior of Aestimia?

megcolek commented 11 years ago

Hey Atul- testing notes included scenario in which the mentor didn't submit additional notes/ comments and tried to approve or not approve the badge.

I'm not sure the intended use case, so was flagged based off testing notes! I'm fine with it either way.

Sent from my iPhone

On Jun 6, 2013, at 4:48 PM, Atul Varma notifications@github.com wrote:

Hmm, by "note" do you mean the response that a mentor fills out when they assess a submission? And are you describing the current behavior of Aestimia, or the desired behavior of Aestimia?

— Reply to this email directly or view it on GitHub.

threeqube commented 11 years ago

I think by note, @megcolek refers to mentor feedback. It seems free text feedback is required in order for mentor to submit their application review. I'm ok with this as a feature for now.