mozilla / remote-settings

Delivering data to Firefox
https://remote-settings.readthedocs.io/
Apache License 2.0
14 stars 13 forks source link

Log messages sent to stdout absent from GCP Log Explorer #595

Open leplatrem opened 7 months ago

leplatrem commented 7 months ago

eg. heartbeat messages, autograph response status, etc.

alexcottner commented 6 months ago

Based on my local testing, I think we at least need to add an explicit log config section for kinto. Example:

[loggers]
keys = root, kinto, summary
....
[logger_kinto]
level = INFO
handlers = console
qualname = kinto
alexcottner commented 6 months ago

Changes have been deployed. We're now seeing at least some logs that we were missing, unsure if this is everything. New log types we're seeing:

leplatrem commented 6 months ago

update: that's already a big improvement :) thank you @alexcottner and GG for spotting the culprit

We instantiate logger in kinto_remote_settings too.

https://github.com/mozilla/remote-settings/blob/96b025c40d2545c6789a5f11c3853d5612fadff5/kinto-remote-settings/src/kinto_remote_settings/signer/utils.py#L17

Does this mean we also have to explicit add it the conf too? I still don't get why root doesn't mean "all"